Skip to content

Conversation

@jakubno
Copy link
Member

@jakubno jakubno commented Oct 16, 2025

Note

Keep-alive now only extends TTL for running sandboxes (returns 404 otherwise) and adds an integration test asserting 404 when setting timeout during pause.

  • Backend
    • Keep-alive validation: In packages/api/internal/orchestrator/keep_alive.go, KeepAliveFor now returns NotFound if the sandbox State is not running, preventing TTL updates on non-running sandboxes.
  • Tests
    • Integration: Add tests/integration/internal/tests/api/sandboxes/sandbox_set_timeout_test.go to verify setting timeout during sandbox pause returns 404.

Written by Cursor Bugbot for commit f5485d8. This will update automatically on new commits. Configure here.

cursor[bot]

This comment was marked as outdated.

@jakubno jakubno changed the title Add state validation in sandbox update operation Add state validation in sandbox keep alive operation Oct 16, 2025
cursor[bot]

This comment was marked as outdated.

@jakubno jakubno force-pushed the fix-update-when-sandbox-is-already-being-removed branch from a249dd2 to 6189ae2 Compare October 16, 2025 08:54
cursor[bot]

This comment was marked as outdated.

@jakubno jakubno force-pushed the fix-update-when-sandbox-is-already-being-removed branch 2 times, most recently from d18c61e to 8a804ef Compare October 16, 2025 09:01
cursor[bot]

This comment was marked as outdated.

@jakubno jakubno force-pushed the fix-update-when-sandbox-is-already-being-removed branch from 8a804ef to 2a8c00c Compare October 16, 2025 09:14
@jakubno jakubno marked this pull request as draft October 16, 2025 15:35
@jakubno jakubno force-pushed the fix-update-when-sandbox-is-already-being-removed branch from 2a8c00c to 0e986a0 Compare October 27, 2025 13:10
@jakubno jakubno marked this pull request as ready for review October 27, 2025 14:17
@jakubno jakubno merged commit 2b1fdf8 into main Oct 27, 2025
28 checks passed
@jakubno jakubno deleted the fix-update-when-sandbox-is-already-being-removed branch October 27, 2025 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants