Skip to content

Simplify passing envs in makefile #559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

jakubno
Copy link
Member

@jakubno jakubno commented Apr 9, 2025

Description

Instead of passing each env variable one by one, load them dynamically

@jakubno jakubno added the improvement Improvement for current functionality label Apr 9, 2025
@jakubno jakubno self-assigned this Apr 9, 2025
Copy link
Contributor

@dobrac dobrac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it's annoying to define the variables, but we are losing with this track of which variables should be defined, etc.

Also, for the vars with the default value, we're losing ability to define these (not every env has to have correctly setup env vars in the .env file)

@@ -56,17 +66,3 @@ TESTS_ENVD_PROXY=
TESTS_SANDBOX_TEMPLATE_ID=base
# your Team API key
TESTS_E2B_API_KEY=

# <host>:<port> no protocol
CLICKHOUSE_CONNECTION_STRING=
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the clickhouse env removal should be done probably in a different PR

@jakubno
Copy link
Member Author

jakubno commented Apr 10, 2025

I know it's annoying to define the variables, but we are losing with this track of which variables should be defined, etc.

Also, for the vars with the default value, we're losing ability to define these (not every env has to have correctly setup env vars in the .env file)

  • We can set defaults in variables.tf, which I consider cleaner solution than in Makefile
  • I get the argument for explicitly defining the envs, but either the variable is required and it will fail or it is optional and it will behave the same way as it is now

@dobrac
Copy link
Contributor

dobrac commented Apr 10, 2025

I know it's annoying to define the variables, but we are losing with this track of which variables should be defined, etc.
Also, for the vars with the default value, we're losing ability to define these (not every env has to have correctly setup env vars in the .env file)

  • We can set defaults in variables.tf, which I consider cleaner solution than in Makefile
  • I get the argument for explicitly defining the envs, but either the variable is required and it will fail or it is optional and it will behave the same way as it is now

Okay

@ValentaTomas ValentaTomas removed their request for review April 22, 2025 14:31
@jakubno jakubno closed this May 5, 2025
@jakubno jakubno deleted the simplify-passing-envs-in-makefile branch June 3, 2025 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement for current functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants