-
Notifications
You must be signed in to change notification settings - Fork 180
Extract low level UFFD handler to a separate package #973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…el uffd handling to a subpackage
c85fec0 to
855369b
Compare
|
I'll improve the tests a little, but the rest should be ready. |
…-written-to-eng-3093
|
Included in #1385, very hard to merge separately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Extracts low-level UFFD into a new userfaultfd package, replaces mapping with memory map API, wires into orchestrator, and adds robust 4K/2MB tests; CI enables UFFD and hugepages.
userfaultfdpackage (Serve,configureApi,Register,copy,Close).mappingwithmemorypackage (MemfileMap,MemoryMap.GetOffset); update Firecracker mapping and JSON parsing.uffdintegration to useuserfaultfd.NewUserfaultfdFromFd(...).Serve(...); removeTrackAndReturnNil.userfaultfdtests covering 4K and 2MB hugepages; ensure non-flaky behavior.testutilshelpers (NewPageMmap,ContiguousMap, random data, content slicer) andutils.MapKeys.userfaultfdand mounts hugepages before tests.MaskTemplate.Close.Written by Cursor Bugbot for commit dcea5f1. This will update automatically on new commits. Configure here.