Fix ignored result of size calculation of Exception#560
Closed
jaw wants to merge 1 commit intoeProsima:masterfrom
Closed
Fix ignored result of size calculation of Exception#560jaw wants to merge 1 commit intoeProsima:masterfrom
jaw wants to merge 1 commit intoeProsima:masterfrom
Conversation
Not adding the calculated size to the sum would lead to serialization failing thus rendering certain RPC calls unusable. Signed-off-by: Jonatan Wallmander <jonatan.wallmander@kdab.com>
9d0f056 to
a84e72a
Compare
|
Also, separately, the server code generated by fastddsgen could maybe do something about the fact that void execute_request(
const std::shared_ptr<RequestContext>& req)
{
try
{
for (;;)
{
if (req->request.representation_limits.has_value())
{
{
ReplyType reply{};
reply.representation_limits = calculator_example::detail::Calculator_representation_limits_Result{};
reply.representation_limits->result = implementation_->representation_limits(
*req);
replier_->send_reply(&reply, req->info); //<-- ERROR IGNORED
}
break;
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not adding the calculated size to the sum would lead to serialization failing thus rendering certain RPC calls unusable.
Description
To reproduce the bug before this patch solves it, one can use a subset of the RPC example code in fastdds:
IDL code:
Then, in the addition implementation on the server, simply throw
OverflowException.Logs output:
The message will then never be sent.
@Mergifyio backport 4.2.x
Contributor Checklist
Reviewer Checklist