[24015] Remove unused keep alive code by cferreiragonz · Pull Request #6247 · eProsima/Fast-DDS

cferreiragonz · 2026-01-09T10:00:16Z

Description

This PR removes unused code regarding an unimplemented keep alive feature.
It also adds a new types.hpp file to extend TCPTransport layer in Fast DDS Pro

Contributor Checklist

Commit messages follow the project guidelines.
The code follows the style guidelines of this project.
N/A: Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
Any new/modified methods have been properly documented using Doxygen.
N/A: Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
❌ Changes are backport compatible: they do NOT break ABI nor change library core behavior.
N/A: Changes are API compatible.
New feature has been added to the versions.md file (if applicable).
New feature has been documented/Current behavior is correctly described in the documentation.
- Related documentation PR: [24015] Update TCP keep alive docs Fast-DDS-docs#1187
N/A: Applicable backports have been included in the description.

Reviewer Checklist

The PR has a milestone assigned.
The title and description correctly express the PR's purpose.
Check contributor checklist is correct.
If this is a critical bug fix, backports to the critical-only supported branches have been requested.
Check CI results: changes do not issue any warning.
Check CI results: failing tests are unrelated with the changes.

cferreiragonz · 2026-01-09T10:21:47Z

It might be interesting to partially backport the Warning when TCP keep alive is configured, as it won't have any impact

mergify · 2026-01-12T15:49:52Z

🧪 CI Insights

Here's what we observed from your CI run for f59657d.

❌ Job Failures

Pipeline	Job	Retries	🔍 CI Insights	📄 Logs
`Fast DDS MacOS CI`	`mac-ci / fastdds_test ()`	`0`	View	View
`Fast DDS Windows CI`	`windows-ci / fastdds_test (RelWithDebInfo, examples), v142`	`0`	View	View
`Fast DDS Windows CI`	`windows-ci / fastdds_test (RelWithDebInfo, examples), v143`	`0`	View	View

src/cpp/rtps/transport/TCPChannelResourceSecure.h

MiguelCompany

We should please uncrustify, but should first wait for eProsima/code-style#12 to be merged

cferreiragonz · 2026-01-15T15:50:52Z

466960c introduces changes to correctly update remote endpoints when locators of a known Data(p) are modified. b7a3763 avoids creating resources for own locators after update_attributes is called. Uncrustify updated after eProsima/code-style#12 merged

src/cpp/rtps/builtin/discovery/participant/PDPListener.cpp

src/cpp/rtps/builtin/discovery/participant/PDP.h

src/cpp/rtps/builtin/discovery/participant/PDP.cpp

src/cpp/rtps/builtin/discovery/participant/PDPClient.cpp

src/cpp/rtps/builtin/discovery/participant/PDPServer.cpp

include/fastdds/rtps/common/RemoteLocators.hpp

src/cpp/rtps/builtin/discovery/participant/PDP.h

src/cpp/rtps/builtin/discovery/participant/PDPClient.h

src/cpp/rtps/builtin/discovery/participant/PDPServer.hpp

src/cpp/rtps/builtin/discovery/participant/PDPSimple.h

src/cpp/rtps/builtin/discovery/database/DiscoveryDataBase.cpp

cferreiragonz · 2026-01-27T08:46:06Z

I am rebasing this after #6273

Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com>

Co-authored-by: Miguel Company <miguelcompany@eprosima.com> Signed-off-by: Carlos Ferreira González <carloos.499@gmail.com>

Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com>

cferreiragonz added this to the v3.5.0 milestone Jan 9, 2026

cferreiragonz added ci-pending PR which CI is running fast dds pro labels Jan 9, 2026

cferreiragonz requested review from richiprosima and removed request for richiprosima January 9, 2026 11:34

MiguelCompany force-pushed the master branch from f5aaab5 to 338f840 Compare January 12, 2026 07:01

cferreiragonz requested review from richiprosima and removed request for richiprosima January 12, 2026 07:07

MiguelCompany requested changes Jan 12, 2026

View reviewed changes

src/cpp/rtps/transport/TCPChannelResourceSecure.h Outdated Show resolved Hide resolved

src/cpp/rtps/transport/TCPChannelResourceSecure.h Outdated Show resolved Hide resolved

cferreiragonz requested a review from MiguelCompany January 13, 2026 06:56

MiguelCompany requested changes Jan 13, 2026

View reviewed changes

cferreiragonz force-pushed the fast/poc/keep_alive branch 3 times, most recently from 62e28a6 to 68b85c8 Compare January 15, 2026 15:45

cferreiragonz force-pushed the fast/poc/keep_alive branch from 68b85c8 to 439854b Compare January 16, 2026 07:04

cferreiragonz requested a review from MiguelCompany January 16, 2026 07:04

MiguelCompany requested changes Jan 16, 2026

View reviewed changes

cferreiragonz requested a review from MiguelCompany January 16, 2026 12:52

cferreiragonz force-pushed the fast/poc/keep_alive branch from 9220fe1 to 060146e Compare January 19, 2026 06:44

cferreiragonz requested review from richiprosima and removed request for richiprosima January 19, 2026 06:56

MiguelCompany previously approved these changes Jan 19, 2026

View reviewed changes

cferreiragonz dismissed MiguelCompany’s stale review via a169f16 January 19, 2026 15:57

cferreiragonz requested a review from MiguelCompany January 19, 2026 15:57

MiguelCompany reviewed Jan 20, 2026

View reviewed changes

src/cpp/rtps/builtin/discovery/database/DiscoveryDataBase.cpp Outdated Show resolved Hide resolved

cferreiragonz force-pushed the fast/poc/keep_alive branch from a169f16 to 34a8594 Compare January 20, 2026 07:33

cferreiragonz dismissed MiguelCompany’s stale review via c13a9b9 January 21, 2026 10:11

cferreiragonz force-pushed the fast/poc/keep_alive branch from 34a8594 to c13a9b9 Compare January 21, 2026 10:11

cferreiragonz requested a review from MiguelCompany January 21, 2026 10:14

MiguelCompany approved these changes Jan 21, 2026

View reviewed changes

cferreiragonz added the needs rebase label Jan 23, 2026

cferreiragonz and others added 19 commits January 27, 2026 09:48

Refs #24015: Remove unused keep_alive logic

5c52305

Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com>

Refs #24015: Channel Resource from types and includes

7e03e02

Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com>

Refs #24015: TCP Transport from types

8675dc7

Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com>

Refs #24015: Warning pro feature

de1a953

Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com>

Refs #24015: Protect channel_resources clear with mutex

6847924

Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com>

Refs #24015: Return existing channel as output in bind_socket

12fd9fb

Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com>

Refs #24015: Doxygen

7cb32af

Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com>

Refs #24015: Fix build errors

5e3cdaa

Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com>

Refs #24015: Apply Miguel's suggestions

40daa5b

Co-authored-by: Miguel Company <miguelcompany@eprosima.com> Signed-off-by: Carlos Ferreira González <carloos.499@gmail.com>

Refs #24015: Update endpoints after new locators in existing Data(p)

89eb259

Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com>

Refs #24015: Fix sender resources creation

6e5eda3

Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com>

Refs #24015: Uncrustify

8752d4f

Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com>

Refs #24015: Revision - Refactor RemoteLocatorList

cb6c1f9

Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com>

Refs #24015: Revision - PDP internal method to notify

b6ac993

Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com>

Refs #24015: Revision - assignRemoteEndpoints changes

1f39819

Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com>

Refs #24015: Revision - Doxygen & remove default arg

7f32ca0

Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com>

Refs #24015: Fix test build

62c67a4

Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com>

Refs #24015: Uncrustify 2

83c04a9

Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com>

Refs #24015: Fix build in Ubuntu24

f59657d

Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com>

cferreiragonz force-pushed the fast/poc/keep_alive branch from c13a9b9 to f59657d Compare January 27, 2026 08:50

cferreiragonz requested a review from richiprosima January 27, 2026 08:51

cferreiragonz removed the needs rebase label Jan 27, 2026

cferreiragonz removed the request for review from richiprosima January 27, 2026 08:51

cferreiragonz closed this Feb 20, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[24015] Remove unused keep alive code#6247

[24015] Remove unused keep alive code#6247
cferreiragonz wants to merge 19 commits intomasterfrom
fast/poc/keep_alive

cferreiragonz commented Jan 9, 2026 •

edited by MiguelCompany

Loading

Uh oh!

cferreiragonz commented Jan 9, 2026

Uh oh!

mergify bot commented Jan 12, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

MiguelCompany left a comment

Uh oh!

cferreiragonz commented Jan 15, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cferreiragonz commented Jan 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

cferreiragonz commented Jan 9, 2026 • edited by MiguelCompany Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Contributor Checklist

Reviewer Checklist

Uh oh!

cferreiragonz commented Jan 9, 2026

Uh oh!

mergify bot commented Jan 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🧪 CI Insights

❌ Job Failures

Uh oh!

Uh oh!

Uh oh!

MiguelCompany left a comment

Choose a reason for hiding this comment

Uh oh!

cferreiragonz commented Jan 15, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cferreiragonz commented Jan 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

cferreiragonz commented Jan 9, 2026 •

edited by MiguelCompany

Loading

mergify bot commented Jan 12, 2026 •

edited

Loading