Skip to content

[23859] Update CMake minimum required and Tier1#6274

Merged
rsanchez15 merged 27 commits intomasterfrom
feature/update_cmake_minimum_to_noble
Feb 26, 2026
Merged

[23859] Update CMake minimum required and Tier1#6274
rsanchez15 merged 27 commits intomasterfrom
feature/update_cmake_minimum_to_noble

Conversation

@raulojeda22
Copy link
Contributor

@raulojeda22 raulojeda22 commented Jan 23, 2026

Description

  • Update Tier 1 from Ubuntu Jammy to Ubuntu Noble.
  • CI jobs now run ubuntu-24
  • CI jobs now use cmakeVersion 3.28.6
  • cmake_minimum_required version upgraded to 3.28
  • Use CMAKE_COMPILE_WARNING_AS_ERROR instead of custom flags in CMakeLists
  • Use swig4.1
  • Keep using ubuntu 22 and GCC12 in tsan
  • Use osrf 2.3.0
  • Fix null-dereference in asio alternative builds

Current state

  • Everything works, except flaky tests and:
  • Tsan is not working, even though we use gcc-12 as in ubuntu22

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@raulojeda22 raulojeda22 requested review from richiprosima and removed request for richiprosima January 23, 2026 12:13
@github-actions github-actions bot added the ci-pending PR which CI is running label Jan 23, 2026
@raulojeda22 raulojeda22 requested review from richiprosima and removed request for richiprosima January 26, 2026 07:18
@raulojeda22 raulojeda22 changed the title Update CMake minimum required and Tier1 [23859] Update CMake minimum required and Tier1 Jan 26, 2026
@raulojeda22 raulojeda22 requested review from richiprosima and removed request for richiprosima January 27, 2026 10:38
@raulojeda22 raulojeda22 added this to the v3.5.0 milestone Jan 28, 2026
@raulojeda22 raulojeda22 requested review from richiprosima and removed request for richiprosima January 28, 2026 10:44
@mergify
Copy link
Contributor

mergify bot commented Jan 28, 2026

🧪 CI Insights

Here's what we observed from your CI run for e7298c0.

❌ Job Failures

Pipeline Job Health on master Retries 🔍 CI Insights 📄 Logs
Fast DDS MacOS CI mac-ci / fastdds_test () Unknown 0 View View
Fast DDS Ubuntu CI ubuntu-ci / fastdds_test (RelWithDebInfo) Unknown 0 View View
Fast DDS Windows CI windows-ci / fastdds_test (RelWithDebInfo, examples), v142 Unknown 0 View View
windows-ci / fastdds_test (RelWithDebInfo, examples), v143 Unknown 0 View View

@raulojeda22 raulojeda22 requested review from richiprosima and removed request for richiprosima January 29, 2026 09:25
@raulojeda22 raulojeda22 requested review from richiprosima and removed request for richiprosima February 23, 2026 09:14
@raulojeda22 raulojeda22 force-pushed the feature/update_cmake_minimum_to_noble branch from 2ffa929 to 3025b53 Compare February 23, 2026 09:38
Signed-off-by: Raül <raulojeda@eprosima.com>
Signed-off-by: Raül <raulojeda@eprosima.com>
Signed-off-by: Raül <raulojeda@eprosima.com>
Signed-off-by: Raül <raulojeda@eprosima.com>
Signed-off-by: Raül <raulojeda@eprosima.com>
Signed-off-by: Raül <raulojeda@eprosima.com>
@raulojeda22 raulojeda22 force-pushed the feature/update_cmake_minimum_to_noble branch from 77aac4e to 13a7346 Compare February 24, 2026 14:04
Signed-off-by: Raül <raulojeda@eprosima.com>
@emiliocuestaf emiliocuestaf removed the ci-pending PR which CI is running label Feb 25, 2026
@emiliocuestaf emiliocuestaf self-requested a review February 25, 2026 08:11
@github-actions github-actions bot added the ci-pending PR which CI is running label Feb 25, 2026
Signed-off-by: Raül <raulojeda@eprosima.com>
@raulojeda22 raulojeda22 requested review from emiliocuestaf and removed request for emiliocuestaf February 25, 2026 08:18
Signed-off-by: Raül <raulojeda@eprosima.com>
@raulojeda22 raulojeda22 requested review from emiliocuestaf and removed request for emiliocuestaf February 25, 2026 08:27
Signed-off-by: Raül <raulojeda@eprosima.com>
@raulojeda22 raulojeda22 requested review from emiliocuestaf and removed request for emiliocuestaf February 25, 2026 09:00
@emiliocuestaf emiliocuestaf added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. labels Feb 25, 2026
@emiliocuestaf emiliocuestaf self-requested a review February 26, 2026 07:47
Copy link
Contributor

@emiliocuestaf emiliocuestaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

# GCC 11.3 (Ubuntu Jammy default) produces several false positives regarding timed synchronization protocols
# These issues were fixed in GCC 12 so we upgrade to that version.
# GCC 13.2 (Ubuntu Noble default) produces several data races warnings
# TODO: For now we keep it at GCC 12 and ubuntu 22 until we figure out what to do with them
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the comment :)

@emiliocuestaf emiliocuestaf added the ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. label Feb 26, 2026
@rsanchez15 rsanchez15 merged commit 5d3acdc into master Feb 26, 2026
37 of 46 checks passed
@rsanchez15 rsanchez15 deleted the feature/update_cmake_minimum_to_noble branch February 26, 2026 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-pending PR which CI is running ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants