[24079] Apply uncrustify to all source files

[raulojeda22]

Description

Given the recent upgrade to Uncrustify-0.78.1 and the new code style configuration, this PR runs the uncrustify on all the source files that:

• Are not in thirdparty folder
• End in the file extensions .h, .hpp, .cpp or .cxx
• Are not files generated by fastddsgen
• Are not the file sqlite3.h
• An exception is the file ./src/cpp/fastdds/xtypes/dynamic_types/idl_parser/custom_rules/SeqUntilManualStop.hpp, which for some reason gets stuck forever when uncrustified gets run on it

Script used:

function all_eprosima_uncrustify ()
{
    (
        function is_generated_file ()
        {
            # Check if file contains the fastddsgen marker
            if grep -q "This file was generated by the tool fastddsgen" "$1" 2>/dev/null; then
                return 0  # true - it is generated
            else
                return 1  # false - it is not generated
            fi
        }

        function uncrustify_ ()
        {
            for file in "$@";
            do
                # Skip if file is generated by fastddsgen
                if is_generated_file "${file}"; then
                    echo "Skipping generated file: ${file}"
                    continue
                fi
                
                uncrustify -c ~/Documents/eprosima/code-style/uncrustify.cfg -f "${file}" -o "${file}" --no-backup > /dev/null;
            done
        }

        local OUTPUT=""

        OUTPUT=$(\
            git ls-files \
            | grep -v -E thirdparty \
            | grep -e '\.h$' -e '\.hpp$' -e '\.cpp$' -e '\.cxx$' \
            | grep -v -E SeqUntilManualStop.hpp # This file gets stuck on uncrustify
        )

        for file in ${OUTPUT};
        do
            uncrustify_ "${file}";
        done
    )
}

all_eprosima_uncrustify had to be run twice, and then the following manual changes were needed, since my local uncrustify wasnt exactly doing the same as the CI uncrustify:

Code style divergence in file 'src/cpp/rtps/history/PoolConfig.h':

--- src/cpp/rtps/history/PoolConfig.h
+++ src/cpp/rtps/history/PoolConfig.h.uncrustify
@@ -43,4 +43,4 @@
-        MemoryManagementPolicy_t policy,
-        uint32_t payload_size,
-        uint32_t ini_size,
-        uint32_t max_size) noexcept
+            MemoryManagementPolicy_t policy,
+            uint32_t payload_size,
+            uint32_t ini_size,
+            uint32_t max_size) noexcept
@@ -48,2 +48,2 @@
-    , initial_size(ini_size)
-    , maximum_size(max_size)
+        , initial_size(ini_size)
+        , maximum_size(max_size)

Code style divergence in file 'src/cpp/rtps/security/SecurityManager.h':

--- src/cpp/rtps/security/SecurityManager.h
+++ src/cpp/rtps/security/SecurityManager.h.uncrustify
@@ -397 +397 @@
-                AuthenticationStatus auth_status)
+                    AuthenticationStatus auth_status)
@@ -409 +409 @@
-                AuthenticationInfo && auth) noexcept
+                    AuthenticationInfo&& auth) noexcept
@@ -441 +441 @@
-                const AuthenticationInfo& auth) = delete;
+                    const AuthenticationInfo& auth) = delete;
@@ -908 +908 @@
-            DatawriterCryptoHandle * wh)
+                DatawriterCryptoHandle * wh)
@@ -921 +921 @@
-            DatareaderCryptoHandle * rh)
+                DatareaderCryptoHandle * rh)

Code style divergence in file 'src/cpp/rtps/security/accesscontrol/ParticipantSecurityAttributes.h':

--- src/cpp/rtps/security/accesscontrol/ParticipantSecurityAttributes.h
+++ src/cpp/rtps/security/accesscontrol/ParticipantSecurityAttributes.h.uncrustify
@@ -51 +51 @@
-        const PluginParticipantSecurityAttributesMask mask)
+            const PluginParticipantSecurityAttributesMask mask)
@@ -129 +129 @@
-        const ParticipantSecurityAttributesMask mask)
+            const ParticipantSecurityAttributesMask mask)

Code style divergence in file 'src/cpp/rtps/transport/test_UDPv4Transport.h':

--- src/cpp/rtps/transport/test_UDPv4Transport.h
+++ src/cpp/rtps/transport/test_UDPv4Transport.h.uncrustify
@@ -71 +71 @@
-            std::atomic<uint8_t>& percent)
+                std::atomic<uint8_t>& percent)

Code style divergence in file 'src/cpp/security/accesscontrol/DistinguishedName.h':

--- src/cpp/security/accesscontrol/DistinguishedName.h
+++ src/cpp/security/accesscontrol/DistinguishedName.h.uncrustify
@@ -112 +112 @@
-        const DistinguishedName& name);
+            const DistinguishedName& name);
@@ -115 +115 @@
-        const char* name);
+            const char* name);

Code style divergence in file 'src/cpp/security/cryptography/AESGCMGMAC_KeyFactory.h':

--- src/cpp/security/cryptography/AESGCMGMAC_KeyFactory.h
+++ src/cpp/security/cryptography/AESGCMGMAC_KeyFactory.h.uncrustify
@@ -42 +42 @@
-        AESGCMGMAC_KeyFactory & factory);
+            AESGCMGMAC_KeyFactory& factory);

After @Danipiza revised several issues regarding the new style, a new config was created and all_eprosima_uncrustify was run twice again.

Contributor Checklist

• Commit messages follow the project guidelines.
• The code follows the style guidelines of this project.
• N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
• N/A Any new/modified methods have been properly documented using Doxygen.
• N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
• Changes are backport compatible: they do NOT break ABI nor change library core behavior.
• Changes are API compatible.
• N/A New feature has been added to the versions.md file (if applicable).
• N/A New feature has been documented/Current behavior is correctly described in the documentation.
• N/A: Applicable backports have been included in the description.

Reviewer Checklist

• The PR has a milestone assigned.
• The title and description correctly express the PR's purpose.
• Check contributor checklist is correct.
• N/A: If this is a critical bug fix, backports to the critical-only supported branches have been requested.
• Check CI results: changes do not issue any warning.
• Check CI results: failing tests are unrelated with the changes.

[Danipiza]

Partial review

[Danipiza]

Use this new code-style branch to uncrustify the files
eProsima/code-style#15

[raulojeda22]

Uncrustify will fail until new code-style is merged to master

[mergify]

🧪 CI Insights

Here's what we observed from your CI run for cb3a431.

❌ Job Failures

Pipeline	Job	Health on master	Retries	🔍 CI Insights	📄 Logs
Fast DDS MacOS CI	mac-ci / fastdds_test ()		0	View	View
Fast DDS Windows CI	windows-ci / fastdds_test (RelWithDebInfo, examples), v142		0	View	View
	windows-ci / fastdds_test (RelWithDebInfo, examples), v143		0	View	View

[Danipiza]

LGTM