Conversation
kwonkwonn
requested review from
Jbchan01 and
Copilot
and removed request for
Copilot
Contributor
Author
|
Inst가 Get에서 사용되는 경우는 많지가 않음. |
Contributor
Author
|
최종적으론 GenerateFactory*에서도 inst를 인자로 받지 않게 해서, instHandler 를 아예지우는 것이 목표. |
Jbchan01
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Summary
libvirt.Con이 의미없이 인자로 전달되는 것이 아닌 내부 필드로 세팅후 참조할 수 있도록 수정
Related Issue
Closes #98
Test Plan
make testpasses