Conversation
|
🎊 Navigate the preview: https://6a6753de94edff2b03ea3d34--eclipse-che-docs-pr.netlify.app 🎊 |
Bitbucket Cloud updated their terminology from "OAuth consumer" to "OAuth client". Updated procedure files to reflect the new naming and revised UI steps. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
JTBD + CQA 2.1 review
JTBD mapping
This content maps to Integrate > Enable credential-free Git access for developers (integrate_git), specifically Job 32: Enable credential-free Git access for developers — "When connecting to version control, I want to enable credential-free authentication with our Git providers so that developers can push and pull code without managing individual credentials."
Upstream JTBD PR: #3151 (Integrate)
PR #3151 moves the OAuth configuration pages from modules/administration-guide/ into the Integrate module. Same situation as PR #3170:
Option A (preferred): Merge #3171 first since it is a small terminology fix. When #3151 rebases, it picks up the renamed files and updated terminology automatically. The file moves cleanly because #3151 does a git mv of the entire partials directory.
Option B: Merge #3151 first, then rebase #3171 to target the new Integrate module paths. Either way works — this is a simpler case than #3170 because the files are just renamed/replaced, not restructured.
| . In the *Details* tab enter *{prod-short}* as the *Name*. | ||
|
|
||
| . In the *Authorization* tab click the *Authorization code* checkbox and enter `pass:c,a,q[{prod-url}]/api/oauth/callback` as the *Callback URL*. | ||
|
|
There was a problem hiding this comment.
Typo: "Copes" should be "Scopes"
| . In the *Scopes* tab check all of the *Account* and *Repositories* checkboxes, and click *Save*. |
| // :page-aliases: | ||
|
|
||
| [id="setting-up-an-oauth-client-in-the-bitbucket-cloud"] | ||
| = Setting up an OAuth client in the Bitbucket Cloud |
There was a problem hiding this comment.
Gerund title — use imperative
Per CQA 2.1 and JTBD title rules, procedure titles must use imperative verbs. Also update the :navtitle: and :description: to match.
| = Setting up an OAuth client in the Bitbucket Cloud | |
| = Set up an OAuth client in the Bitbucket Cloud |
Note: The downstream JTBD title for this procedure is "Create a Bitbucket Cloud OAuth client for {prod-short}" — even more user-goal-driven. Consider aligning upstream with a similar pattern.
| . In the *Authorization* tab click the *Authorization code* checkbox and enter `pass:c,a,q[{prod-url}]/api/oauth/callback` as the *Callback URL*. | ||
|
|
||
| . In the *Copes* tab check all of the *Account* and *Repositories* checkboxes, and click *Save*. | ||
|
|
There was a problem hiding this comment.
Trailing colon should be a period
Line ends with : instead of .
| . Copy and save the *Client ID* value for use when applying the Bitbucket OAuth client Secret. |
| . Copy and save the *Client ID* value for use when applying the Bitbucket OAuth client Secret: | ||
|
|
||
| . Copy and save the *Secret* value for use when applying the Bitbucket OAuth client Secret. | ||
|
|
There was a problem hiding this comment.
Missing [role="_additional-resources"]
Per DITA compliance, the role attribute is required before .Additional resources.
| [role="_additional-resources"] | |
| .Additional resources |
| :keywords: bitbucket, bitbucket-cloud, oauth-client, bitbucket-oauth-client, oauth-application | ||
| :navtitle: Setting up an OAuth client in the Bitbucket Cloud | ||
| // :page-aliases: | ||
|
|
There was a problem hiding this comment.
Missing :page-aliases: for URL redirect
The old file proc_setting-up-an-oauth-consumer-in-the-bitbucket-cloud.adoc was deleted and this new file replaces it. To avoid breaking existing bookmarks and search engine links, add a page alias:
| [id="setting-up-an-oauth-client-in-the-bitbucket-cloud"] |
Also consider adding :page-aliases: proc_setting-up-an-oauth-consumer-in-the-bitbucket-cloud.adoc to the metadata.
| [id="applying-an-oauth-consumer-secret-for-the-bitbucket-cloud"] | ||
| = Applying an OAuth consumer Secret for the Bitbucket Cloud | ||
| [id="applying-an-oauth-client-secret-for-the-bitbucket-cloud"] | ||
| = Applying an OAuth client Secret for the Bitbucket Cloud |
There was a problem hiding this comment.
Gerund title — use imperative
| = Applying an OAuth client Secret for the Bitbucket Cloud | |
| = Apply an OAuth client Secret for the Bitbucket Cloud |
Also update :navtitle: and :description: to match.
| = Applying an OAuth client Secret for the Bitbucket Cloud | ||
|
|
||
| Prepare and apply an OAuth consumer Secret for the Bitbucket Cloud. | ||
| Prepare and apply an OAuth client Secret for the Bitbucket Cloud. |
There was a problem hiding this comment.
Title-abstract verb mismatch
Title verb is "Applying" (or after fix: "Apply"), but the abstract starts with "Prepare". Per CQA 2.1, the first verb in the title must match the first verb in the abstract.
| Prepare and apply an OAuth client Secret for the Bitbucket Cloud. | |
| Apply an OAuth client Secret for the Bitbucket Cloud. |
| stringData: | ||
| id: __<Bitbucket_Oauth_Consumer_Key>__ <2> | ||
| secret: __<Bitbucket_Oauth_Consumer_Secret>__ <3> | ||
| id: __<Bitbucket_Oauth_client_Key>__ <2> |
There was a problem hiding this comment.
Inconsistent casing in YAML placeholders
Oauth should be OAuth (capital A), and client should be Client for consistency with the proper noun "OAuth client".
| id: __<Bitbucket_Oauth_client_Key>__ <2> | |
| id: __<Bitbucket_OAuth_Client_Key>__ <2> | |
| secret: __<Bitbucket_OAuth_Client_Secret>__ <3> |
| @@ -12,6 +12,6 @@ You can enable users to work with a remote Git repository that is hosted in the | |||
| . Set up an OAuth consumer (OAuth 2.0) in the Bitbucket Cloud. | |||
There was a problem hiding this comment.
Parent page lead-in text not updated
The include paths were updated but the lead-in text still says "OAuth consumer". This should be updated to match the new Bitbucket terminology:
| . Set up an OAuth consumer (OAuth 2.0) in the Bitbucket Cloud. | |
| . Set up an OAuth client (OAuth 2.0) in the Bitbucket Cloud. | |
| . Apply an OAuth client Secret for the Bitbucket Cloud. |
What does this pull request change?
Bitbucket Cloud updated their terminology from "OAuth consumer" to "OAuth client". Updated procedure files to reflect the new naming and revised UI steps.
What issues does this pull request fix or reference?
https://redhat.atlassian.net/browse/CRW-11735
Specify the version of the product this pull request applies to
Pull Request checklist
The author and the reviewers validate the content of this pull request with the following checklist, in addition to the automated tests.
Validate language on files added or modifiedstep reports no vale warnings.