add throttling option to the thingSearch persistence updater #2125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thjaeckle
requested changes
Feb 18, 2025
There was a problem hiding this comment.
Awesome work @hu-ahmed
Thanks a lot.
I would name the "throttling" config more specific.
Reasoning: We should make clear what is throttled. And we maybe need to add another throttling config for something else at the same config in the future.
It is about throttling after a policy update - so e.g. name it (also everywhere else, including the config) maybe: getPolicyModificationCausedSearchIndexUpdateThrottling()
...java/org/eclipse/ditto/thingsearch/service/common/config/DefaultSearchPersistenceConfig.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/eclipse/ditto/thingsearch/service/common/config/SearchPersistenceConfig.java
Outdated
Show resolved
Hide resolved
thjaeckle
reviewed
Feb 18, 2025
...java/org/eclipse/ditto/thingsearch/service/common/config/DefaultSearchPersistenceConfig.java
Outdated
Show resolved
Hide resolved
thjaeckle
reviewed
Feb 18, 2025
thjaeckle
reviewed
Feb 18, 2025
...c/main/java/org/eclipse/ditto/thingsearch/service/common/config/SearchPersistenceConfig.java
Show resolved
Hide resolved
thjaeckle
reviewed
Feb 18, 2025
...se/ditto/thingsearch/service/persistence/write/impl/MongoThingsSearchUpdaterPersistence.java
Outdated
Show resolved
Hide resolved
thjaeckle
reviewed
Feb 18, 2025
...se/ditto/thingsearch/service/persistence/write/impl/MongoThingsSearchUpdaterPersistence.java
Outdated
Show resolved
Hide resolved
thjaeckle
reviewed
Feb 18, 2025
thjaeckle
reviewed
Feb 18, 2025
…r policy update
hu-ahmed
force-pushed
the
provide-search-index-throttle-config
branch
from
a8a159f to
4d501ae
Compare
thjaeckle
reviewed
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #2122 by adding throttling config