Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add namespace to all Helm managed k8s resources #2130

Merged
merged 1 commit into from
Feb 25, 2025
Merged

add namespace to all Helm managed k8s resources #2130

merged 1 commit into from
Feb 25, 2025

Conversation

thjaeckle
Copy link
Member

No description provided.

@thjaeckle thjaeckle added this to the 3.7.0 milestone Feb 24, 2025
@thjaeckle thjaeckle self-assigned this Feb 24, 2025
@thjaeckle
Copy link
Member Author

@kalinkostashki or @alstanchev could you have a look?
One of our toolings linting Helm charts reported that we did not use namespace - so I added them to all k8s resources in the chart.

kalinkostashki
kalinkostashki suggested changes Feb 25, 2025
View reviewed changes
Copy link
Contributor

@kalinkostashki kalinkostashki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not clear on the use of $root instead of .Release.Namespace

kalinkostashki
kalinkostashki approved these changes Feb 25, 2025
View reviewed changes
Copy link
Contributor

@kalinkostashki kalinkostashki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@thjaeckle thjaeckle merged commit 692ffdf into eclipse-ditto:master Feb 25, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalinkostashki kalinkostashki

Assignees

@thjaeckle thjaeckle

Labels
Helm chart
Projects
Ditto Planning
Status: Done
Milestone
3.7.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@thjaeckle @kalinkostashki