fix pre-defined extraFields were causing missing extra from Thing created events #2137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alstanchev could you have a look, please? |
thjaeckle
force-pushed
the
bugfix/fix-pre-defined-extra-fields-for-created-events
branch
from
8633e24 to
56b32f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the in Ditto 3.7.0 added "pre-defined" extraFields configuration
ThingCreatedevents did not contain the configured "extra" fields if pre-defined extra-fields were configured.The reason was that the Policy is not yet available during creation of the Thing and thus, no fields were added to
extraas authorization was missing.This PR provides a fix which solves this by doing a roundtrip and extra-fields retrieval in such (rare) cases of thing creation.
It also improves how it is calculated if all asked for "extra" fields were available as pre-configured fields.