Skip to content

fix http-push-connection-dispatcher config overrides #2139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 5, 2025
Merged

fix http-push-connection-dispatcher config overrides #2139

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8e91b1b
fix http-push-connection-dispatcher config overrides
alstanchev Mar 4, 2025
864cf82
add some doc to the thread-pool-executor props
alstanchev Mar 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 24 additions & 4 deletions connectivity/service/src/main/resources/connectivity.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1329,11 +1329,31 @@ http-push-connection-dispatcher {
# This executor is meant to be allowed to grow quite big as its limited by the max parallelism of each http connection client.
# Limit this parallelism here additionally could lead to confusing results regarding througput of some http connections.
# The core-pool-size-min remains unchanged so its quite small (8). Unused threads will expire after 60s.
core-pool-size-factor = 2147483647
core-pool-size-factor = ${?HTTP_PUSH_CORE_POOL_SIZE_FACTOR}

core-pool-size-max = 2147483647
core-pool-size-max = ${?HTTP_PUSH_CORE_POOL_SIZE_MAX}
thread-pool-executor {
# The core-pool-size-factor is used to determine corePoolSize of the
# ThreadPoolExecutor using the following formula:
# ceil(available processors * factor).
# Resulting size is then bounded by the core-pool-size-min and
# core-pool-size-max values.
# Increasing can help aleviate errors of type "Dropped message as result of backpressure strategy!" during high load.
core-pool-size-factor = 4
core-pool-size-factor = ${?HTTP_PUSH_CORE_POOL_SIZE_FACTOR}
# Max number of threads to cap factor-based corePoolSize number to
core-pool-size-max = 64
core-pool-size-max = ${?HTTP_PUSH_CORE_POOL_SIZE_MAX}
# Minimum number of threads to cap factor-based maximumPoolSize number to
max-pool-size-min= 64
max-pool-size-min= ${?HTTP_PUSH_POOL_SIZE_MAX}
# Max number of threads to cap factor-based maximumPoolSize number to
max-pool-size-max = 512
max-pool-size-max= ${?HTTP_PUSH_POOL_SIZE_MAX}

# Allow core threads to time out
allow-core-timeout = on
# Keep alive time for threads
keep-alive-time = 60s
}
}

kafka-consumer-dispatcher {
Expand Down
Loading