Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include notice and license in published artifacts, switch them to md … #949

Merged
merged 1 commit into from
Nov 2, 2020

Conversation

lukasj
Copy link
Member

@lukasj lukasj commented Oct 31, 2020

…format

Signed-off-by: Lukas Jungmann [email protected]

@lukasj lukasj requested a review from rfelcman October 31, 2020 14:07
Copy link
Contributor

@rfelcman rfelcman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

about.html, ... movement to features directory. Are these html files used now?


* License: Apache-2.0 AND W3C AND LicenseRef-Public-Domain

Apache Ant (1.10.7)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's twice there.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is generated file


* License: BSD-3-Clause

ASM 9 (n/a)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ASM (9.0)

License: BSD-3-Clause

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

again, generated file

spring-agent (2.5.3)

* License: Apache License, 2.0
* Project: http://www.springframework.org
* Source:
http://downloads.sourceforge.net/springframework/spring-framework-2.5.3-with-dependencies.zip?modtime=1204283106&big_mirror=0

spring-aop (5.2.0)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, that all spring components are under Apache-2.0 license.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you see Apache-2.0 license missing somewhere? Some pieces are dual-licensed

@lukasj
Copy link
Member Author

lukasj commented Nov 2, 2020

about.html, ... movement to features directory. Are these html files used now?

do we build features? in either case, html files make sense for eclipse-plugin packaging type or features. It makes no sense to have them in plain jars

Copy link
Contributor

@rfelcman rfelcman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukasj lukasj merged commit a1836bf into eclipse-ee4j:master Nov 2, 2020
@lukasj lukasj deleted the lic branch November 2, 2020 09:34
dtaimanov added a commit to jmix-framework/eclipselink that referenced this pull request Apr 21, 2023
… fetches eclipse-ee4j#949 Andrey Subbotin 28.02.2019, 16:42 d739b3f4 (d154d181)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants