Migrate tests to JUnit5 #1825
Open
Migrate tests to JUnit5 #1825
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Replace annotations with JUnit5 equivalents * Use JUnit5 Assertions (and statically import them) * Upgrade to XMLUnit 2.x to support JUnit5 * Clean-up some assertions (flipped arguments, simplifications)
Author
|
@lukasj Kindly requesting a review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to migrate all tests to JUnit5. Changes include:
The only exceptions are tests suites in
jaxb.osgi_testthat rely onorg.apache.felix.ipojo.junit4osgi.OSGiTestSuitefor which there seems to be no equivalent that is compatible with JUnit5.Verified with
mvn clean installthat build passes before and after my changes.Overall number of tests and coverage did not change.
I am well aware that the changeset is rather big but still hope that it is managable to review. Please let me know if there are any further questions to my changes.