[599] Add better support for resolution of wildcard types. #661
Conversation
jamezp
force-pushed
the
issue599
branch
2 times, most recently
from
332fada to
72781a6
Compare
| @@ -233,7 +233,7 @@ private ModelDeserializer<JsonParser> createObjectDeserializer(LinkedList<Type> | |||
| if (creatorModel.getCustomization().isRequired()) { | |||
| defaultCreatorValues.put(parameterName, new RequiredCreatorParameter(parameterName)); | |||
| } else { | |||
| Class<?> rawParamType = ReflectionUtils.getRawType(creatorModel.getType()); | |||
| Class<?> rawParamType = ReflectionUtils.getOptionalRawType(creatorModel.getType()).orElse(Object.class); | |||
There was a problem hiding this comment.
I'm not 100% sure if this is the correct place to fix this. I did attempt to fix it by defaulting to Optional.of(Object.class) in the ReflecionUtils.getOptionalRawType(). However, that did break some tests and I wasn't sure if that was correct either.
| @@ -1,5 +1,5 @@ | |||
| /* | |||
| * Copyright (c) 2015, 2023 Oracle and/or its affiliates. All rights reserved. | |||
| * Copyright (c) 2025 Oracle and/or its affiliates. All rights reserved. | |||
There was a problem hiding this comment.
According to Eclipse Foundation, when omitting the second date, you must keep the remaining one unchanged.
There was a problem hiding this comment.
Ah, right. I had it backwards. I'll fix that to simply remove the second date and keep the first date.
There was a problem hiding this comment.
Well, that fails the copyright check. I'm not sure what the right approach is.
There was a problem hiding this comment.
This means, the copyright check is not compliant to the rules set up by the Eclipse Foundation, simply spoken. Things like this often happens if POMs were copied (or authored) from Oracle.
There was a problem hiding this comment.
@mkarg does the code change for the fix look ok? I have a user hitting this as a regression when moving from yasson2 to yasson3 , Thanks !
There was a problem hiding this comment.
It is up to the Yasson committers to decide.
There was a problem hiding this comment.
@m0mus According to Eclipse Foundation's rules, all projects MUST accept the short form having only the initial publication date (see https://www.eclipse.org/projects/handbook/#ip-copyright-headers). Apparently Yasson's POM.xml expects to find the latest date, which is wrong. What is your decision how to proceed?
Signed-off-by: James R. Perkins <[email protected]>
Signed-off-by: James R. Perkins <[email protected]>
|
I've added an additional commit to not check the year when validating the copyright. |
Signed-off-by: James R. Perkins <[email protected]>
|
Hi @jamezp , sorry for the delay. I will take a look :-) |
|
Awesome, thank you @Verdent! I know it's a big ask, but is there a release schedule for this by chance? I'm happy to run some TCK's against WildFly and a SNAPSHOT of this first if that helps. |
This should resolve the following:
Overall, this should improve the way some of the wildcard types are resolved. The fix in
ReflectionUtilswas for an issue filed against JBoss EAP. If we need another issue here for this, please let me know. However, it seemed the two above may cover it.