Skip to content

initial import of "hat"#1

Open
ctron wants to merge 1 commit into
eclipse-hono:masterfrom
ctron:feature/add_hat_1
Open

initial import of "hat"#1
ctron wants to merge 1 commit into
eclipse-hono:masterfrom
ctron:feature/add_hat_1

Conversation

@ctron
Copy link
Copy Markdown

@ctron ctron commented Apr 3, 2020

No description provided.

@ctron ctron force-pushed the feature/add_hat_1 branch 2 times, most recently from 8d696f0 to 232444b Compare September 3, 2020 07:45
@ctron ctron marked this pull request as ready for review September 3, 2020 07:45
@ctron ctron force-pushed the feature/add_hat_1 branch from 232444b to a7dcee7 Compare September 3, 2020 07:56
Copy link
Copy Markdown

@sophokles73 sophokles73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't review any of the code (I don't speak Rust) ...
Does the tool already work with the Device Registry Management API or has it been developed against the original HTTP API?

Comment thread hat/README.md

Or by setting the environment variable `HAT_TENANT`:

HAT_TENANT=foo hat device create 4711
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should probably be

HAT_TENANT=my-tenant

right?

Comment thread hat/hat.wxi
<?define PlatformProgramFilesFolder = "ProgramFiles64Folder" ?>
<?define ProductUpgradeCode = "1b4094a4-2add-11e9-b676-c85b762e5a2c" ?>

</Include> No newline at end of file
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing EOL?

Comment thread hat/hat.wxs
</Feature>

</Product>
</Wix> No newline at end of file
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing EOL?

@ctron
Copy link
Copy Markdown
Author

ctron commented Sep 11, 2020

I didn't review any of the code (I don't speak Rust) ...
Does the tool already work with the Device Registry Management API or has it been developed against the original HTTP API?

This works only with the new API.

@calohmn
Copy link
Copy Markdown
Contributor

calohmn commented Nov 18, 2020

@ctron Any updates regarding the comments above?

Comment thread hat/README.md
@@ -0,0 +1,167 @@
# HAT – Hono Admin Tool [![GitHub release](https://img.shields.io/github/release/ctron/hat.svg)](https://github.com/ctron/hat/releases)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better remove the image here? It refers and links to the ctron/hat repository (and the version number is 0.7.1, not the 0.7.2 defined here).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants