Skip to content

Add attribute ID validation and fix null UserWriteMask handling #1625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: 1.0
Choose a base branch
from
Open

Add attribute ID validation and fix null UserWriteMask handling #1625

wants to merge 1 commit into from

Conversation

kevinherron
Copy link
Contributor

Summary

  • Validates attribute IDs in read and write access checks
  • Returns Bad_AttributeIdInvalid for invalid attribute IDs
  • Allows operations when UserWriteMask is null so they fail with Bad_NodeIdUnknown instead of Bad_UserAccessDenied
  • Adds javadoc for AccessResult constants
  • Adds tests for invalid attribute IDs and null UserWriteMask handling

Fixes #1624

@kevinherron
Add attribute ID validation and fix null UserWriteMask handling
a3074d2 
- Validate attribute IDs in read and write access checks
- Return Bad_AttributeIdInvalid for invalid attribute IDs
- Allow operations when UserWriteMask is null so they fail with
  Bad_NodeIdUnknown instead of Bad_UserAccessDenied
- Add javadoc for AccessResult constants
- Add tests for invalid attribute IDs and null UserWriteMask handling

Fixes #1624
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CTT - Attribute Write Values - Err-004, Err-005, Err-006

1 participant

@kevinherron