Reject native methods in isRecursiveMethodTarget()#7730
Merged
0xdaryl merged 1 commit intoeclipse-omr:masterfrom Apr 17, 2025
Merged
Reject native methods in isRecursiveMethodTarget()#77300xdaryl merged 1 commit intoeclipse-omr:masterfrom
0xdaryl merged 1 commit intoeclipse-omr:masterfrom
Conversation
A native linkage adapter must not be considered to be making a recursive call, or else the code generator could encode the call instruction as a recursive call to the JIT body instead of the intended call to the native implementation. So far we've been avoiding that situation by having isSameMethod() return false for native methods, which is confusing. By rejecting native methods explicitly here, it will now be possible to correct this problem in isSameMethod().
Contributor
Author
|
@0xdaryl, could you please review? |
Contributor
|
Jenkins build all |
0xdaryl
approved these changes
Apr 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A native linkage adapter must not be considered to be making a recursive call, or else the code generator could encode the call instruction as a recursive call to the JIT body instead of the intended call to the native implementation.
So far we've been avoiding that situation by having
isSameMethod()return false for native methods, which is confusing. By rejecting native methods explicitly here, it will now be possible to correct this problem inisSameMethod().