Skip to content

JFR dump to Jcmd current working directory by default #21076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 7, 2025

Conversation

JasonFengJ9
Copy link
Member

@JasonFengJ9 JasonFengJ9 commented Feb 6, 2025

JFR dump to Jcmd current working directory by default

If the filename supplied is not an absolute path, Jcmd current work directory is used instead of the target VM location;
Throw an error if the duration option doesn't have time units.

Related to

Signed-off-by: Jason Feng [email protected]

@JasonFengJ9
Copy link
Member Author

@tajila This is ready for review.

@tajila
Copy link
Contributor

tajila commented Apr 2, 2025

jenkins test sanity.functional xlinux jdk17

Copy link
Contributor

@tajila tajila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an issue where an invalid time is provided but the recording is still started. I think you need to start recording after you parse all the options.

If the filename supplied is not an absolute path, Jcmd current work
directory is used instead of the target VM location;
Throw an error if the duration option doesn't have any time unit.

Signed-off-by: Jason Feng <[email protected]>
@JasonFengJ9
Copy link
Member Author

There is an issue where an invalid time is provided but the recording is still started. I think you need to start recording after you parse all the options.

Moved VM.startJFR() after the successful parseTimeParameter("duration", parameters).

@tajila this is ready for another look.

@JasonFengJ9 JasonFengJ9 requested a review from tajila April 3, 2025 16:36
@tajila
Copy link
Contributor

tajila commented Apr 3, 2025

jenkins test sanity.functional xlinux jdk17

@tajila tajila merged commit 6e5f670 into eclipse-openj9:master Apr 7, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants