-
Notifications
You must be signed in to change notification settings - Fork 752
JFR dump to Jcmd current working directory by default #21076
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
9618102
to
5cef172
Compare
5cef172
to
377fc8b
Compare
@tajila This is ready for review. |
jenkins test sanity.functional xlinux jdk17 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is an issue where an invalid time is provided but the recording is still started. I think you need to start recording after you parse all the options.
If the filename supplied is not an absolute path, Jcmd current work directory is used instead of the target VM location; Throw an error if the duration option doesn't have any time unit. Signed-off-by: Jason Feng <[email protected]>
Moved @tajila this is ready for another look. |
jenkins test sanity.functional xlinux jdk17 |
JFR dump to Jcmd current working directory by default
If the filename supplied is not an absolute path,
Jcmd
current work directory is used instead of the target VM location;Throw an error if the duration option doesn't have time units.
Related to
Signed-off-by: Jason Feng [email protected]