Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Test_org_eclipse_swt_browser_Browser::ignoreNonDisposedShells #1666

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Remove Test_org_eclipse_swt_browser_Browser::ignoreNonDisposedShells #1666

merged 1 commit into from
Dec 16, 2024

Conversation

fedejeanne
Copy link
Contributor

@fedejeanne fedejeanne commented Dec 16, 2024 •
edited
Loading

Fixes #1668

@github-actions GitHub Actions
Copy link
Contributor

Test Results

   383 files  ±0     383 suites  ±0   5m 3s ⏱️ +2s
 4 284 tests ±0   4 271 ✅ ±0  13 💤 ±0  0 ❌ ±0 
12 147 runs  ±0  12 064 ✅ ±0  83 💤 ±0  0 ❌ ±0 

Results for commit 13546d7. ± Comparison against base commit 1ced8a9.

@fedejeanne fedejeanne marked this pull request as ready for review December 16, 2024 13:33
@fedejeanne
Copy link
Contributor Author

Linux failures are unrelated to this PR: #1653

@fedejeanne fedejeanne merged commit 9339c92 into eclipse-platform:master Dec 16, 2024
10 of 14 checks passed
@fedejeanne fedejeanne deleted the check_shells branch December 16, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iloveeclipse iloveeclipse Awaiting requested review from iloveeclipse

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Field "ignoreNonDisposedShells" in Test_org_eclipse_swt_browser_Browser hides a faulty check
1 participant
@fedejeanne