Auto pin behavior for opening new console #2240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mehmet-karaman
force-pushed
the
auto_pin_console
branch
2 times, most recently
from
1972493 to
ecec74e
Compare
Contributor
mehmet-karaman
force-pushed
the
auto_pin_console
branch
2 times, most recently
from
ac36083 to
7240aea
Compare
...se.debug.ui/ui/org/eclipse/debug/internal/ui/preferences/DebugPreferencesMessages.properties
Outdated
Show resolved
Hide resolved
mehmet-karaman
force-pushed
the
auto_pin_console
branch
from
7240aea to
f8bf07b
Compare
debug/org.eclipse.ui.console/src/org/eclipse/ui/internal/console/messages.properties
Outdated
Show resolved
Hide resolved
mehmet-karaman
force-pushed
the
auto_pin_console
branch
from
f8bf07b to
6718b67
Compare
debug/org.eclipse.ui.console/src/org/eclipse/ui/internal/console/ConsoleViewConsoleFactory.java
Show resolved
Hide resolved
mehmet-karaman
force-pushed
the
auto_pin_console
branch
2 times, most recently
from
b0341f3 to
13a1dd5
Compare
debug/org.eclipse.ui.console/src/org/eclipse/ui/internal/console/OpenConsoleAction.java
Outdated
Show resolved
Hide resolved
...se.debug.ui/ui/org/eclipse/debug/internal/ui/preferences/DebugPreferencesMessages.properties
Outdated
Show resolved
Hide resolved
mehmet-karaman
force-pushed
the
auto_pin_console
branch
3 times, most recently
from
7b021b9 to
65e344e
Compare
debug/org.eclipse.ui.console/src/org/eclipse/ui/internal/console/OpenConsoleAction.java
Outdated
Show resolved
Hide resolved
debug/org.eclipse.ui.console/src/org/eclipse/ui/internal/console/ConsoleViewConsoleFactory.java
Outdated
Show resolved
Hide resolved
debug/org.eclipse.ui.console/src/org/eclipse/ui/internal/console/ConsoleViewConsoleFactory.java
Outdated
Show resolved
Hide resolved
debug/org.eclipse.ui.console/src/org/eclipse/ui/console/IConsoleConstants.java
Outdated
Show resolved
Hide resolved
debug/org.eclipse.ui.console/src/org/eclipse/ui/console/IConsoleConstants.java
Show resolved
Hide resolved
...org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/preferences/ConsolePreferencePage.java
Outdated
Show resolved
Hide resolved
mehmet-karaman
force-pushed
the
auto_pin_console
branch
from
65e344e to
47bcce1
Compare
Contributor
|
LGTM. @iloveeclipse anything to add or can I merge this? |
iloveeclipse
requested changes
Nov 12, 2025
Member
iloveeclipse
left a comment
iloveeclipse
left a comment
There was a problem hiding this comment.
I have one comment/change request regarding new behavior and few issues with the rest of the new code.
debug/org.eclipse.ui.console/src/org/eclipse/ui/internal/console/ConsoleViewConsoleFactory.java
Show resolved
Hide resolved
debug/org.eclipse.ui.console/src/org/eclipse/ui/internal/console/ConsoleViewConsoleFactory.java
Show resolved
Hide resolved
debug/org.eclipse.ui.console/src/org/eclipse/ui/internal/console/Messages.java
Outdated
Show resolved
Hide resolved
debug/org.eclipse.ui.console/src/org/eclipse/ui/internal/console/Messages.java
Outdated
Show resolved
Hide resolved
debug/org.eclipse.ui.console/src/org/eclipse/ui/internal/console/messages.properties
Outdated
Show resolved
Hide resolved
debug/org.eclipse.ui.console/src/org/eclipse/ui/internal/console/ConsoleView.java
Outdated
Show resolved
Hide resolved
debug/org.eclipse.ui.console/src/org/eclipse/ui/internal/console/OpenConsoleAction.java
Show resolved
Hide resolved
debug/org.eclipse.ui.console/src/org/eclipse/ui/internal/console/OpenConsoleAction.java
Outdated
Show resolved
Hide resolved
...org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/preferences/ConsolePreferencePage.java
Show resolved
Hide resolved
debug/org.eclipse.ui.console/src/org/eclipse/ui/internal/console/ConsoleViewConsoleFactory.java
Outdated
Show resolved
Hide resolved
mehmet-karaman
force-pushed
the
auto_pin_console
branch
2 times, most recently
from
338e090 to
ee23411
Compare
Member
|
@mehmet-karaman : I see you've pushed new commit but some of the comments are still not resolved. Does it mean, you plan to push yet another change, should I wait with the review till then? |
...se.debug.ui/ui/org/eclipse/debug/internal/ui/preferences/DebugPreferencesMessages.properties
Outdated
Show resolved
Hide resolved
| PatternMatchListenerExtension_5=is missing required enablement expression and will be removed | ||
| UpdatingConsoleState=Updating console state | ||
| UpdatingConsoleState=Updating console state | ||
| TurnOnAutoPinDialogMessage=If a new Console view is opened, it's possible to auto pin the old Console view and new Console view to keep its content. Would you like to turn on the auto pin? |
Member
There was a problem hiding this comment.
What about this:
Should we pin the old and new Console views (so different console pages could be updated independently)?
Member
There was a problem hiding this comment.
Original PR version:
Proposed one:
Improved proposal:
debug/org.eclipse.ui.console/src/org/eclipse/ui/internal/console/OpenConsoleAction.java
Outdated
Show resolved
Hide resolved
mehmet-karaman
force-pushed
the
auto_pin_console
branch
from
ee23411 to
33e79be
Compare
Contributor
Author
No.. I wanted to recheck before resolving them.. After amend + push I couldn't see your comments.. It looks like there is a new feature of github, which is working differently.. Switched to classic and now I can see all again.. |
mehmet-karaman
force-pushed
the
auto_pin_console
branch
from
33e79be to
fedeafc
Compare
mehmet-karaman
force-pushed
the
auto_pin_console
branch
from
fedeafc to
1c65fb4
Compare
iloveeclipse
requested changes
Nov 13, 2025
Member
iloveeclipse
left a comment
iloveeclipse
left a comment
There was a problem hiding this comment.
I believe messages and dialog title need a change, I will push all requested changes now and also I will rebase on latest master.
debug/org.eclipse.ui.console/src/org/eclipse/ui/internal/console/ConsoleMessages.properties
Outdated
Show resolved
Hide resolved
debug/org.eclipse.ui.console/src/org/eclipse/ui/internal/console/ConsoleMessages.properties
Outdated
Show resolved
Hide resolved
...g.eclipse.ui.console/src/org/eclipse/ui/internal/console/ConsoleUIPreferenceInitializer.java
Outdated
Show resolved
Hide resolved
debug/org.eclipse.ui.console/src/org/eclipse/ui/internal/console/ConsoleViewConsoleFactory.java
Outdated
Show resolved
Hide resolved
- Added "auto pin behavior" for the Console view. If user opens a new Console view from opened Console, it will raise the question if Consoles should be pinned or not. - Added new preference to the ConsolePreferencePage - Bu default the preference will be enabled See eclipse-platform#2240
iloveeclipse
force-pushed
the
auto_pin_console
branch
from
1c65fb4 to
8f2bf10
Compare
iloveeclipse
approved these changes
Nov 13, 2025
Member
|
@mehmet-karaman : please provide N&N for the change. |
Contributor
Author
|
The N&N PR: eclipse-platform/www.eclipse.org-eclipse#438 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The console view has a "pin console" action, which pins the current console. If the user wants a new console, the original one should be pinned, otherwise a console switch will switch all unpinned console views.
console, it will raise the question if auto pin should be done.