-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up CMake configs #838
Merged
LukasWoodtli
merged 5 commits into
eclipse-wakaama:main
from
husqvarnagroup:lw/default_config
Dec 17, 2024
Merged
Clean up CMake configs #838
LukasWoodtli
merged 5 commits into
eclipse-wakaama:main
from
husqvarnagroup:lw/default_config
Dec 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c8c087e
to
b73feda
Compare
rettichschnidi
requested changes
Dec 5, 2024
3e89d8f
to
f4b3c3f
Compare
rettichschnidi
approved these changes
Dec 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, only one nit
98d2f5f
to
d845fbc
Compare
Deleting block data in any case.
bad87b7
to
6de7a79
Compare
Working on the project is easier, when all modes and most other features are enabled by default. The baseline for CodeChecker needs to be adjusted, because more code is now analyzed. It just reports more findings of issues that were already around before.
Presets never worked very well. Especially IDE's had troubles with them.
This way it's easier to handle the different kind of tests.
This way the Wakaama library is built and tested with the configurations that the examples use.
6de7a79
to
0d1f6fd
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some clean-ups. Also add sanitized integration tests.