Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up CMake configs #838

Merged
merged 5 commits into from
Dec 17, 2024

Conversation

LukasWoodtli
Copy link
Contributor

@LukasWoodtli LukasWoodtli commented Dec 4, 2024

Some clean-ups. Also add sanitized integration tests.

@LukasWoodtli LukasWoodtli marked this pull request as draft December 4, 2024 16:05
@LukasWoodtli LukasWoodtli force-pushed the lw/default_config branch 4 times, most recently from c8c087e to b73feda Compare December 4, 2024 20:09
@LukasWoodtli LukasWoodtli force-pushed the lw/default_config branch 5 times, most recently from 3e89d8f to f4b3c3f Compare December 9, 2024 20:04
@LukasWoodtli LukasWoodtli marked this pull request as ready for review December 9, 2024 20:08
Copy link
Contributor

@rettichschnidi rettichschnidi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only one nit

@LukasWoodtli LukasWoodtli force-pushed the lw/default_config branch 2 times, most recently from 98d2f5f to d845fbc Compare December 17, 2024 14:12
Deleting block data in any case.
@LukasWoodtli LukasWoodtli force-pushed the lw/default_config branch 2 times, most recently from bad87b7 to 6de7a79 Compare December 17, 2024 15:13
Working on the project is easier, when all modes and most other features
are enabled by default.

The baseline for CodeChecker needs to be adjusted, because more code is
now analyzed. It just reports more findings of issues that were already
around before.
Presets never worked very well. Especially IDE's had troubles with them.
This way it's easier to handle the different kind of tests.
This way the Wakaama library is built and tested with the configurations
that the examples use.
@LukasWoodtli LukasWoodtli merged commit 8493582 into eclipse-wakaama:main Dec 17, 2024
81 checks passed
@LukasWoodtli LukasWoodtli deleted the lw/default_config branch January 20, 2025 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants