Local messages optimisation #1066
Open
+2,454
−186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR missing one of the required labels: {'internal', 'breaking-change', 'dependencies', 'documentation', 'bug', 'api-sync', 'ci', 'new feature', 'enhancement'} |
steils
force-pushed
the
localisation
branch
9 times, most recently
from
bb9cc11 to
a88f739
Compare
sashacmc
reviewed
Oct 21, 2025
Member
sashacmc
left a comment
sashacmc
left a comment
There was a problem hiding this comment.
I only did a passing review, so a full review from @gmartin82 is still needed.
steils
force-pushed
the
localisation
branch
4 times, most recently
from
368dd75 to
45b8d49
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
steils
force-pushed
the
localisation
branch
2 times, most recently
from
e7df8e4 to
420527c
Compare
gmartin82
suggested changes
Oct 22, 2025
gmartin82
suggested changes
Oct 23, 2025
|
No description provided. |
steils
force-pushed
the
localisation
branch
2 times, most recently
from
b65eaa1 to
82ce34f
Compare
steils
force-pushed
the
localisation
branch
2 times, most recently
from
7888446 to
30b1771
Compare
steils
force-pushed
the
localisation
branch
27 times, most recently
from
43a18ea to
f45bc81
Compare
- Deliver PUT/DELETE, query, reply, and reply-final messages for a key expression that is defined in the same local session locally, without causing network activity. - Extend z_api_source_info_test to validate deliveries both to remote and local subscribers. - Support locality of samples to be received by subscribers or targeted by publishers. - Enable the locality-specific CMake options in CI. User can now set allowed_origin / allowed_destination in z_put_options_t, z_publisher_put_options_t, z_subscriber_options_t, z_queryable_options_t, etc. with the following values: - ZP_LOCALITY_SESSION_LOCAL - stay inside the session (don't send anything to network) - ZP_LOCALITY_REMOTE - send/accept only over the transport (no same-session samples) - ZP_LOCALITY_ANY - allow both, exactly as with zenoh-c's zc_locality_t. Co-developed-by: Denis Biryukov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there is a subscription or query request for a key expression that is defined in the same local session, the response must be processed locally and not cause network activity.