Skip to content

Fix writer-side filtering in peer mode. #1096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sashacmc merged 2 commits into from
Nov 25, 2025
Merged

Fix writer-side filtering in peer mode. #1096

sashacmc merged 2 commits into from
Nov 25, 2025

Conversation

@gmartin82
Copy link
Contributor

@gmartin82 gmartin82 commented Nov 20, 2025 •
edited
Loading

Ensure _Z_INTEREST_FLAG_KEYEXPRS and _Z_INTEREST_FLAG_FUTURE flags are included in interests when connected to a router in peer mode.

Fixes pub (peer) > router > sub (client) communication.

Closes #1075.

@github-actions
Copy link

github-actions bot commented Nov 20, 2025

PR missing one of the required labels: {'breaking-change', 'api-sync', 'internal', 'documentation', 'enhancement', 'new feature', 'ci', 'dependencies', 'bug'}

@gmartin82 gmartin82 added the bug Something isn't working label Nov 20, 2025
github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 20, 2025
View reviewed changes
@gmartin82 gmartin82 force-pushed the issue-1075 branch 2 times, most recently from 0b465bf to b1f3e19 Compare November 20, 2025 16:25
github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 20, 2025
View reviewed changes
github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 20, 2025
View reviewed changes
@gmartin82 gmartin82 force-pushed the issue-1075 branch 2 times, most recently from 4f4aef3 to 1582103 Compare November 20, 2025 16:52
@gmartin82 gmartin82 changed the title Fix pub (peer) > router > sub (client) communication. Fix writer-side filtering in peer mode. Nov 20, 2025
github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 21, 2025
View reviewed changes
tests/routed_peer_client.py
DIR_EXAMPLES = "build/examples"


def pub_and_sub(pub_args, sub_args, pub_first=True):

Check notice

Code scanning / Pylintpython3 (reported by Codacy)

Too many local variables (18/15) Note test

Too many local variables (18/15)
github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 21, 2025
View reviewed changes
tests/routed_peer_client.py
DIR_EXAMPLES = "build/examples"


def pub_and_sub(pub_args, sub_args, pub_first=True):

Check notice

Code scanning / Pylintpython3 (reported by Codacy)

Too many statements (55/50) Note test

Too many statements (55/50)
@gmartin82 gmartin82 force-pushed the issue-1075 branch 4 times, most recently from c086c6a to 1df6b56 Compare November 21, 2025 13:09
@gmartin82
Add test to check that pub (peer) > router > sub (client) works as ex…
81b8e13 
…pected.

Test checks the following scenarios:

* TCP Unicast
* UDP Multicast
* Pub starting first
* Sub starting first
@gmartin82 gmartin82 force-pushed the issue-1075 branch 2 times, most recently from 7ba2a5e to a581781 Compare November 21, 2025 13:48
@gmartin82
Fix writer-side filtering in peer mode.
62cb2b8 
Ensure correct interest flags are sent when connected to a router in peer mode.
@gmartin82 gmartin82 marked this pull request as ready for review November 21, 2025 14:29
@gmartin82
Copy link
Contributor Author

gmartin82 commented Nov 21, 2025 •
edited
Loading

In order to get the new test to pass through CI I had to set BATCH_UNICAST_SIZE=49152 when building Znoh Pico. Note this is another issue which is solved by this PR: #1093.

PR consists of two commits. The first adds failing tests, the second the fix with passing tests.

@sashacmc sashacmc merged commit 1ff109f into eclipse-zenoh:main Nov 25, 2025
84 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sashacmc sashacmc sashacmc approved these changes

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Writer-side filtering in peer mode

2 participants

@gmartin82 @sashacmc