Typo in RTS signal for UART0 #955
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mani-Sadhasivam
requested changes
Feb 27, 2019
There was a problem hiding this comment.
Hi @focalplane,
Change looks good but as per MRAA contribution guidelines you need to rework this PR. https://github.com/intel-iot-devkit/mraa/blob/master/CONTRIBUTING.md#basic-rules
|
@focalplane thanks for your correction, but yes, specifically, please add a sign-off line into your commit message and add an affected file/module name into the commit message summary. The link @Mani-Sadhasivam shared is the full information on that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.