add dynamic enum Tutorial#278
Merged
lucas-koehler merged 8 commits intoeclipsesource:masterfrom Oct 24, 2025
Merged
Conversation
LukasBoll
force-pushed
the
dynamicEnumTutorial
branch
from
7a344e3 to
7654703
Compare
sdirix
reviewed
Feb 19, 2024
Member
sdirix
left a comment
sdirix
left a comment
There was a problem hiding this comment.
I like it!
Please add a small section at the end that this behavior can be generalized and extracted into React HOCs for cleaner code.
LukasBoll
force-pushed
the
dynamicEnumTutorial
branch
from
3af8f33 to
99d4152
Compare
sdirix
previously requested changes
Mar 20, 2024
LukasBoll
force-pushed
the
dynamicEnumTutorial
branch
from
d2d24bc to
d6205ec
Compare
Co-authored-by: Stefan Dirix <sdirix@eclipsesource.com> closes eclipsesource#270
LukasBoll
force-pushed
the
dynamicEnumTutorial
branch
from
817dd55 to
23fa126
Compare
Contributor
Author
|
thank you, I applied the changes from your review! |
- correctly use `x-dependent` and `x-endpoint` - use useJsonFormsControlProps instead of withJsonFormsEnumProps because options are calculated manually
lucas-koehler
approved these changes
Oct 24, 2025
Contributor
lucas-koehler
left a comment
lucas-koehler
left a comment
There was a problem hiding this comment.
Looked pretty good to me already. I did a few minor fixes regarding wording and using x- prefixed schema properties for endpoint and dependents.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #270