-
Notifications
You must be signed in to change notification settings - Fork 1.5k
feat!: remove vue 2 #830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kingyue737
wants to merge
3
commits into
ecomfe:8.0
Choose a base branch
from
kingyue737:remove-vue2
base: 8.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat!: remove vue 2 #830
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@kingyue737 is attempting to deploy a commit to the EFE Team on Vercel. A member of the Team first needs to authorize it. |
kingyue737
commented
May 11, 2025
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Justineo
requested changes
May 12, 2025
nativeListeners[key.replace(NATIVE_EVENT_RE, "$1")] = listeners[key]; | ||
} else { | ||
realListeners[key] = listeners[key]; | ||
// We are converting all `on<Event>` props to event listeners compatible with Vue 2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to update the comment here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.