Skip to content

fix(image): fix image dont trigger onload event when hit cache #1064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(image): fix image dont trigger onload event when hit cache #1064

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4a6a8b8
fix(image): fix image dont trigger onload event when hit cache
Feb 7, 2024
810d464
fix(image): fix image dont trigger onload event when hit cache
Feb 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/graphic/helper/image.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,12 @@ export function createOrUpdateImage<T>(

if (cachedImgObj) {
image = cachedImgObj.image;
!isImageReady(image) && cachedImgObj.pending.push(pendingWrap);
if (isImageReady(image)) {
onload && onload(image, cbPayload);
}
else {
cachedImgObj.pending.push(pendingWrap);
}
}
else {
image = platformApi.loadImage(
Expand Down