Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI UX improvements #260

Merged
merged 3 commits into from
Mar 6, 2025
Merged

CLI UX improvements #260

merged 3 commits into from
Mar 6, 2025

Conversation

alexcasalboni
Copy link
Contributor

Checklist

  • I have read the Contributor Guide
  • I have read and agree to the Code of Conduct
  • I have added a description of my changes and why I'd like them included in the section below

Description of Changes

  • CLI copyedit pass & shortering a few prompts
  • add highlight/color to output where it makes sense
  • standardize on tracing::info instead of println (unless it's a special case)
  • add help for Editor use and customization (via env variable)

…ing, add help for Editor use and customization
@alexcasalboni alexcasalboni self-assigned this Mar 4, 2025
@coveralls
Copy link

coveralls commented Mar 4, 2025

Pull Request Test Coverage Report for Build 13675441819

Details

  • 0 of 90 (0.0%) changed or added relevant lines in 5 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.3%) to 36.874%

Changes Missing Coverage Covered Lines Changed/Added Lines %
crates/cli/src/commands/components/check.rs 0 1 0.0%
crates/cli/src/commands/components/new.rs 0 7 0.0%
crates/cli/src/commands/components/init.rs 0 9 0.0%
crates/cli/src/commands/components/test.rs 0 9 0.0%
crates/cli/src/commands/components/push.rs 0 64 0.0%
Files with Coverage Reduction New Missed Lines %
crates/cli/src/commands/components/push.rs 3 0.0%
Totals Coverage Status
Change from base Build 13656077794: -0.3%
Covered Lines: 2083
Relevant Lines: 5649

💛 - Coveralls

Copy link
Contributor

@CLEMENTINATOR CLEMENTINATOR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

colors ! lgtm

Comment on lines 31 to 33
let component_category = if CATEGORY_OPTIONS.len() == 1 {
CATEGORY_OPTIONS[0].clone() // Accès direct car on sait qu'il y a un seul élément
CATEGORY_OPTIONS[0].clone() // there is only 1 element
} else {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be simplified into this:

    let component_category = if let [category] = &CATEGORY_OPTIONS[..] {
        category.clone()
    } else {

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙏 I've only touched the comment because it was in French 😆

if that's ok for you, I will leave this for a future refactoring (since it's already working and today I don't have time to test the init command from scratch)

@alexcasalboni alexcasalboni merged commit 4db3ebc into main Mar 6, 2025
6 checks passed
@alexcasalboni alexcasalboni deleted the ux-improvements branch March 6, 2025 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants