-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI UX improvements #260
CLI UX improvements #260
Conversation
…ing, add help for Editor use and customization
Pull Request Test Coverage Report for Build 13675441819Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
colors ! lgtm
let component_category = if CATEGORY_OPTIONS.len() == 1 { | ||
CATEGORY_OPTIONS[0].clone() // Accès direct car on sait qu'il y a un seul élément | ||
CATEGORY_OPTIONS[0].clone() // there is only 1 element | ||
} else { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can be simplified into this:
let component_category = if let [category] = &CATEGORY_OPTIONS[..] {
category.clone()
} else {
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 🙏 I've only touched the comment because it was in French 😆
if that's ok for you, I will leave this for a future refactoring (since it's already working and today I don't have time to test the init command from scratch)
Checklist
Description of Changes