Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cli disocciate slug and name #267

Merged
merged 2 commits into from
Mar 7, 2025
Merged

Conversation

CLEMENTINATOR
Copy link
Contributor

Checklist

  • I have read the Contributor Guide
  • I have read and agree to the Code of Conduct
  • I have added a description of my changes and why I'd like them included in the section below

Description of Changes

components: disasociate slug from name

@CLEMENTINATOR CLEMENTINATOR requested a review from a team as a code owner March 7, 2025 14:56
organization.slug,
component_slug,
).green(),
format!("{}/{}", organization.slug, component_slug,).green(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here (weird comma)

Copy link
Contributor

@alexcasalboni alexcasalboni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 just a couple of weird commas here and there

@coveralls
Copy link

coveralls commented Mar 7, 2025

Pull Request Test Coverage Report for Build 13723778006

Details

  • 0 of 30 (0.0%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.08%) to 36.917%

Changes Missing Coverage Covered Lines Changed/Added Lines %
crates/cli/src/commands/components/init.rs 0 6 0.0%
crates/cli/src/commands/components/push.rs 0 24 0.0%
Files with Coverage Reduction New Missed Lines %
crates/cli/src/commands/components/push.rs 1 0.0%
Totals Coverage Status
Change from base Build 13722774353: 0.08%
Covered Lines: 2091
Relevant Lines: 5664

💛 - Coveralls

@CLEMENTINATOR CLEMENTINATOR force-pushed the cli-disocciate-slug-and-name branch from 36a6bb0 to caba022 Compare March 7, 2025 15:23
@CLEMENTINATOR CLEMENTINATOR merged commit be08d94 into main Mar 7, 2025
6 checks passed
@CLEMENTINATOR CLEMENTINATOR deleted the cli-disocciate-slug-and-name branch March 7, 2025 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants