Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

edgee: credentials: handle profiles #269

Merged
merged 2 commits into from
Mar 10, 2025
Merged

edgee: credentials: handle profiles #269

merged 2 commits into from
Mar 10, 2025

Conversation

CLEMENTINATOR
Copy link
Contributor

Checklist

  • I have read the Contributor Guide
  • I have read and agree to the Code of Conduct
  • I have added a description of my changes and why I'd like them included in the section below

Description of Changes

edgee: credentials: handle profiles

login: can save credentials to profiles
push: can push to a given profile

@CLEMENTINATOR CLEMENTINATOR requested a review from a team as a code owner March 10, 2025 14:29
Copy link
Contributor

@alexcasalboni alexcasalboni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@CLEMENTINATOR CLEMENTINATOR merged commit a7f6654 into main Mar 10, 2025
6 checks passed
@CLEMENTINATOR CLEMENTINATOR deleted the login-profiles branch March 10, 2025 16:06
@coveralls
Copy link

coveralls commented Mar 10, 2025

Pull Request Test Coverage Report for Build 13769174336

Details

  • 0 of 84 (0.0%) changed or added relevant lines in 5 files are covered.
  • 3 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.3%) to 35.879%

Changes Missing Coverage Covered Lines Changed/Added Lines %
crates/api-client/src/lib.rs 0 2 0.0%
crates/cli/src/commands/components/push.rs 0 7 0.0%
crates/cli/src/commands/auth/whoami.rs 0 14 0.0%
crates/cli/src/commands/auth/login.rs 0 29 0.0%
crates/api-client/src/auth.rs 0 32 0.0%
Files with Coverage Reduction New Missed Lines %
crates/api-client/src/auth.rs 1 0.0%
crates/cli/src/commands/auth/login.rs 1 0.0%
crates/cli/src/commands/components/push.rs 1 0.0%
Totals Coverage Status
Change from base Build 13768089533: -0.3%
Covered Lines: 2091
Relevant Lines: 5828

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants