Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli/components): multiple QoL improvements #273

Merged
merged 8 commits into from
Mar 12, 2025
Merged

Conversation

KokaKiwi
Copy link
Contributor

@KokaKiwi KokaKiwi commented Mar 11, 2025

Checklist

  • I have read the Contributor Guide
  • I have read and agree to the Code of Conduct
  • I have added a description of my changes and why I'd like them included in the section below

Description of Changes

  • Use manifest-defined order for the components settings
  • Update component metadata on push even when there is no new version to create (for example: updating the description, icon or visibility)
  • Raise wit-deps default logging level to warning
  • Add a non-interactive mode to components push command

Also add refactoring of the push code to split it into smaller, more maintainable functions

Related Issues

Resolves EDGEE-532 and EDGEE-533

@KokaKiwi KokaKiwi requested a review from a team as a code owner March 11, 2025 15:54
@coveralls
Copy link

coveralls commented Mar 11, 2025

Pull Request Test Coverage Report for Build 13809615216

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 230 (0.0%) changed or added relevant lines in 4 files are covered.
  • 34 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.3%) to 35.381%

Changes Missing Coverage Covered Lines Changed/Added Lines %
crates/cli/src/logger.rs 0 2 0.0%
crates/cli/src/commands/components/test.rs 0 3 0.0%
crates/cli/src/commands/components/init.rs 0 7 0.0%
crates/cli/src/commands/components/push.rs 0 218 0.0%
Files with Coverage Reduction New Missed Lines %
crates/cli/src/commands/components/push.rs 1 0.0%
crates/api-client/src/lib.rs 5 0.0%
crates/api-client/src/auth.rs 28 0.0%
Totals Coverage Status
Change from base Build 13770184040: -0.3%
Covered Lines: 2091
Relevant Lines: 5910

💛 - Coveralls

@alexcasalboni
Copy link
Contributor

I've tested with this manifest:

[component.settings.example]
title = "Example Config Field"
type = "string"

[component.settings.test]
title = "Example Test Field"
type = "string"

[component.settings.abc]
title = "Example abc Field"
type = "string"


[component.settings.activate]
title = "Example bool"
type = "bool"

[component.settings.num]
title = "Example number"
type = "number"

and the console UI looks good 👍

Screenshot 2025-03-11 at 17 31 46

Copy link
Contributor

@alexcasalboni alexcasalboni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@KokaKiwi KokaKiwi requested a review from CLEMENTINATOR March 12, 2025 11:02
@KokaKiwi KokaKiwi merged commit 48ae2e0 into main Mar 12, 2025
6 checks passed
@KokaKiwi KokaKiwi deleted the cli/components-misc branch March 12, 2025 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants