Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): add telemetry #280

Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open

feat(cli): add telemetry #280

wants to merge 21 commits into from

Conversation

KokaKiwi
Copy link
Contributor

Checklist

  • I have read the Contributor Guide
  • I have read and agree to the Code of Conduct
  • I have added a description of my changes and why I'd like them included in the section below

Description of Changes

  • Add telemetry to CLI

Related Issues

Resolves EDGEE-389

@coveralls
Copy link

coveralls commented Mar 12, 2025

Pull Request Test Coverage Report for Build 14085628337

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 270 (0.0%) changed or added relevant lines in 7 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+4.2%) to 39.542%

Changes Missing Coverage Covered Lines Changed/Added Lines %
crates/api-client/src/lib.rs 0 1 0.0%
crates/cli/src/commands/macros.rs 0 1 0.0%
crates/cli/src/commands/auth/mod.rs 0 3 0.0%
crates/cli/src/commands/auth/login.rs 0 4 0.0%
crates/cli/src/main.rs 0 6 0.0%
crates/api-client/src/data_collection.rs 0 88 0.0%
crates/cli/src/telemetry.rs 0 167 0.0%
Files with Coverage Reduction New Missed Lines %
crates/cli/src/main.rs 1 0.0%
Totals Coverage Status
Change from base Build 13921317934: 4.2%
Covered Lines: 2605
Relevant Lines: 6588

💛 - Coveralls

also refactor code so CLI commands have easier ways to do telemetry
@KokaKiwi KokaKiwi marked this pull request as ready for review March 19, 2025 15:21
@KokaKiwi KokaKiwi requested a review from a team as a code owner March 19, 2025 15:21
@KokaKiwi KokaKiwi requested a review from alexcasalboni March 19, 2025 15:22
Copy link
Contributor

@alexcasalboni alexcasalboni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Only a couple of minor comments

@KokaKiwi KokaKiwi requested a review from alexcasalboni March 26, 2025 14:19
Copy link
Contributor

@alexcasalboni alexcasalboni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 before merging, could you please share access to the Amplitude project to double-check how the raw data is showing up?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants