multi wit version loading #288
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -118,7 +118,7 @@ async fn test_data_collection_component(opts: Options) -> anyhow::Result<()> { | |||
| let instance = context | |||
| .get_data_collection_instance(&component_path, &mut store) | |||
| .await?; | |||
| let component = instance.edgee_components_data_collection(); | |||
| let component = instance.edgee_components1_0_0_data_collection(); | |||
There was a problem hiding this comment.
shouldn't this be based on the manifest wit-version?
There was a problem hiding this comment.
yes i just didnt finish the test part
| @@ -1 +1,3 @@ | |||
| edgee = "https://github.com/edgee-cloud/edgee-wit/archive/refs/tags/v1.0.0.tar.gz" | |||
| edgee2 = "https://github.com/edgee-cloud/edgee-wit/archive/refs/tags/v0.5.0.tar.gz" | |||
There was a problem hiding this comment.
we could use the version here too?
There was a problem hiding this comment.
yep, jsut lazyness here
CLEMENTINATOR
force-pushed
the
test-multi-wit-version
branch
3 times, most recently
from
25e11bb to
5aa90ea
Compare
CLEMENTINATOR
force-pushed
the
test-multi-wit-version
branch
from
5aa90ea to
b201d93
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description of Changes
enable edgee to load more than one version of world
this works, but code definitively needs a cleanup