Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: check measurements reproducibility test for images #3654

Open
wants to merge 32 commits into
base: main
Choose a base branch
from

Conversation

miampf
Copy link
Contributor

@miampf miampf commented Feb 18, 2025

Context

Currently, we are not testing if the measurements of released images can be reproduced.

Proposed change(s)

  • Add ./.github/workflows/check_measurements_reproducibility.yml that runs as part of the release workflow or on workflow_dispatch

Additional info

Checklist

  • Run the E2E tests that are relevant to this PR's changes
  • Add labels (e.g., for changelog category)
  • Is PR title adequate for changelog?

@miampf miampf added the no changelog Change won't be listed in release changelog label Feb 18, 2025
Copy link

netlify bot commented Feb 18, 2025

Deploy Preview for constellation-docs canceled.

Name Link
🔨 Latest commit d480781
🔍 Latest deploy log https://app.netlify.com/sites/constellation-docs/deploys/67b7571ad4805300084578f2

@miampf miampf marked this pull request as ready for review February 18, 2025 13:05
Comment on lines +3 to +14
workflow_dispatch:
inputs:
releasetag:
type: string
description: The release to checkout and download.
required: true
workflow_call:
inputs:
releasetag:
type: string
description: The release to checkout and download.
required: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We only create a release tag when publishing the release, so this won't work when calling this workflow during the release pipeline.
Instead, we should accept a version and ref as input.

Where version is the version of the measurements to download from the CDN,
and ref the git ref to check out and build the images from.
For the release workflow this should be the working branch, for workflow_dispatch this can be the same as version, i.e. the tag of the release

@miampf miampf force-pushed the miampf/e2e/test-release-reproducibility branch from b90d79a to 4c94dfb Compare February 20, 2025 10:51
@miampf miampf force-pushed the miampf/e2e/test-release-reproducibility branch from 3bbb6b3 to bc58333 Compare February 20, 2025 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog Change won't be listed in release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants