-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
e2e: check measurements reproducibility test for images #3654
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for constellation-docs canceled.
|
workflow_dispatch: | ||
inputs: | ||
releasetag: | ||
type: string | ||
description: The release to checkout and download. | ||
required: true | ||
workflow_call: | ||
inputs: | ||
releasetag: | ||
type: string | ||
description: The release to checkout and download. | ||
required: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We only create a release tag when publishing the release, so this won't work when calling this workflow during the release pipeline.
Instead, we should accept a version
and ref
as input.
Where version
is the version of the measurements to download from the CDN,
and ref
the git ref to check out and build the images from.
For the release workflow this should be the working branch, for workflow_dispatch
this can be the same as version
, i.e. the tag of the release
b90d79a
to
4c94dfb
Compare
3bbb6b3
to
bc58333
Compare
Context
Currently, we are not testing if the measurements of released images can be reproduced.
Proposed change(s)
./.github/workflows/check_measurements_reproducibility.yml
that runs as part of the release workflow or onworkflow_dispatch
Additional info
Checklist