Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to scala3 ? #26

Merged
merged 5 commits into from
Oct 28, 2024
Merged

Bump to scala3 ? #26

merged 5 commits into from
Oct 28, 2024

Conversation

PapyChacal
Copy link
Collaborator

That would be to match Scair, and facilitate integration.

Biggest changes are a bunch of parentheses that were not needed in Scala 2, and the main method being explicit now:
https://docs.scala-lang.org/scala3/reference/dropped-features/delayed-init.html

Two degenerate default (match) cases were also removed as flagged unnecessary now.

The scala-parser-combinators dependency required a bump to 2.0.0 for Scala3, but this did not seem to imply any code change.

Copy link
Collaborator

@mtghorbani mtghorbani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@mtghorbani mtghorbani merged commit e4ae1d2 into main Oct 28, 2024
2 checks passed
@mtghorbani mtghorbani deleted the emilien/scala3 branch October 28, 2024 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants