Skip to content

Fixes for 0.18#33

Open
jheyd wants to merge 4 commits into
eduran84:masterfrom
jheyd:fixes-for-018
Open

Fixes for 0.18#33
jheyd wants to merge 4 commits into
eduran84:masterfrom
jheyd:fixes-for-018

Conversation

@jheyd

@jheyd jheyd commented Jan 25, 2020

Copy link
Copy Markdown

Updated sprite filenames and set factorio_version in info.json to 0.18

Did not do extensive testing, but the game is able to start and I did not spot any obvious bugs ingame

Comment thread prototypes/sprites.lua Outdated
type = "sprite",
name = "ltnt_warning_sign_sprite",
filename = "__core__/graphics/warning-icon.png",
filename = "__core__/graphics/icons/alers/warning-icon.png",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo. Should be alerts.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@TheBB

TheBB commented Jan 28, 2020

Copy link
Copy Markdown

I also needed to add mip to the path for refresh.png.

@jheyd

jheyd commented Jan 28, 2020

Copy link
Copy Markdown
Author

For some reason I retyped the things from my working / tested version instead of just copying the file and made two mistakes in the process. Sorry for that.

@0ptera

0ptera commented Jan 28, 2020

Copy link
Copy Markdown
Collaborator

I'll leave it to Eduran, if he returns, to merge these changes.
However I feel a pull request for the 0.10.x branch to Factorio 0.18 is redundant, after I already made an 0.18 branch from the 1.0 beta. I've been using 1.0 beta for 6 months now and it feels ready for release.

@TheBB

TheBB commented Jan 29, 2020

Copy link
Copy Markdown

@Yousei9 That branch depends on GUI_Modules. Can you clarify where a 0.18-ready version for that can be found?

@0ptera

0ptera commented Jan 29, 2020

Copy link
Copy Markdown
Collaborator

You will have to port the 0.17 version to 0.18 yourself.
If I recall correctly only the version in info.json needs to be updated.

@TheBB

TheBB commented Jan 29, 2020

Copy link
Copy Markdown

Thanks. Yeah that seems to work. I was confused earlier because the entry button had moved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants