Split code into core and submodules for non-core code#5
Draft
ctadlock wants to merge 2 commits intoedvin:masterfrom
GoToTags:dev
Draft
Split code into core and submodules for non-core code#5ctadlock wants to merge 2 commits intoedvin:masterfrom GoToTags:dev
ctadlock wants to merge 2 commits intoedvin:masterfrom
GoToTags:dev
Conversation
Merge pull request #2 from GoToTags/master
Collaborator
Author
Collaborator
Author
|
@edvin Take a look at this for the structure; you should be able to pull it down and use it. I was able to use it in our app without any issue. If youre OK with this, can then work on moving the components out of core into their other projects. |
Collaborator
|
I converted this PR to a draft/WIP to prevent accidental merging. When you're ready for it to be merged, mark it as "Ready for review". |
Collaborator
Author
Thanks. Ill be the one to merge it anyways, but good to follow the right process. |
Collaborator
Author
|
Going to merge this in and start moving forward... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first commit for this merge request. DO NOT MERGE YET
Items:
tornadofx-coresubmodulepom.xmlfiles