fix: inconsistent loading of discussion thread response#368
Open
naincy128 wants to merge 2 commits into
Open
Conversation
naincy128
marked this pull request as ready for review
June 29, 2026 06:17
santhosh-apphelix-2u
approved these changes
Jun 29, 2026
naincy128
force-pushed
the
naincy128/LP-529
branch
from
July 3, 2026 06:34
dd3702c to
328420c
Compare
naincy128
force-pushed
the
naincy128/LP-529
branch
from
July 6, 2026 05:45
5e9d21f to
e28fc4c
Compare
Comment on lines
+2336
to
2344
| # Filter muted content | ||
| include_muted_param = request.GET.get("include_muted", False) | ||
| include_muted_param = include_muted_param in ["true", "True", True] | ||
| if not include_muted_param: | ||
| response_comments = filter_muted_content( | ||
| request.user, | ||
| context["course"].id, | ||
| response_comments | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue where inline replies within discussion threads could load inconsistently, causing some replies to appear or disappear between page refreshes.
Root Cause
Response comments were not being retrieved using backend-level pagination. Combined with frontend request race conditions and stale state handling, this could result in inconsistent loading of inline replies, especially in threads with many responses.
As a result, users could see different combinations of replies on successive page refreshes, even though the underlying discussion data was unchanged.
Changes
Backend (edx-platform)
Frontend (frontend-app-discussions)
Linked PR
frontend-app-discussions
Ticket
LP-529