Skip to content

Conversation

urwithsumit
Copy link
Contributor

#603

Corrected Driver.scala version pattern match for dispatch-core 2.0.0 version.
Udpate Log4j to the latest 2.24.x and fixed Log.scala to support the updated log4j jars.
Update scala 2.13 version to the latest 2.13.16
Updated default version of Dispatch-core to 1.2.0 and updated the corresponding pattern to support the .y in Driver.scala

sumit_kumar and others added 5 commits February 3, 2025 17:12
…ing against this version. From the project the version of the dispatch-core can be configured using the configuration, compile / scalaxb / scalaxbDispatchVersion.

Since the supporting templates are been added to the scalaxb, the dispatch-core 2.0.0 version should work fine.

eed3si9n#673
Corrected Driver.scala version pattern match for dispatch-core 2.0.0 version.
Udpate Log4j to the latest 2.24.x and fixed Log.scala to support the updated log4j jars.
Update scala 2.13 version to the latest 2.13.16
Updated default version of Dispatch-core to 1.2.0 and updated the corresponding pattern to support the .y in Driver.scala
@urwithsumit
Copy link
Contributor Author

@eed3si9n

I made some corrections to the changes I made for dispatch-core in my earlier pull request.
Along with it, I also took the opportunity to fix the log4j for this project.
Hope you should be able to close the #603 post this merge completes.

Let me know if you feel these changes to be done in separate pull requests.

Thanks!

case class Log(logger: Logger) {
def info(message: String, args: Any*): Unit = {
if (args.toSeq.isEmpty) logger.info(message)
if (args.isEmpty) logger.info(message)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you split refactoring into another PR plz?

object Dependencies {
val scala3 = "3.3.1"
val scala213 = "2.13.12"
val scala213 = "2.13.16"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a separate PR

// Same as 0.13.x
generateDispatchFromResource(style, "/httpclients_dispatch0130", config)
case (VersionPattern(1, 0 | 1, _), style) =>
case (VersionPattern(1, 0 | 1 | 2, _), style) =>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we split these fixes to another PR and add a scripted test that's called only for JDK 11+?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure on the 2nd part of writing the scripted test case for JDK 11+ part. Can you guide me on how to achieve it?

@urwithsumit
Copy link
Contributor Author

closing this pull request. Will open new ones as per review comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants