-
Notifications
You must be signed in to change notification settings - Fork 160
Updates for https://github.com/eed3si9n/scalaxb/issues/603 + Version updates for Scala 2.13 + minor updates. #680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… version are flagged in security scans. eed3si9n#673
…ing against this version. From the project the version of the dispatch-core can be configured using the configuration, compile / scalaxb / scalaxbDispatchVersion. Since the supporting templates are been added to the scalaxb, the dispatch-core 2.0.0 version should work fine. eed3si9n#673
Corrected Driver.scala version pattern match for dispatch-core 2.0.0 version. Udpate Log4j to the latest 2.24.x and fixed Log.scala to support the updated log4j jars. Update scala 2.13 version to the latest 2.13.16 Updated default version of Dispatch-core to 1.2.0 and updated the corresponding pattern to support the .y in Driver.scala
I made some corrections to the changes I made for dispatch-core in my earlier pull request. Let me know if you feel these changes to be done in separate pull requests. Thanks! |
case class Log(logger: Logger) { | ||
def info(message: String, args: Any*): Unit = { | ||
if (args.toSeq.isEmpty) logger.info(message) | ||
if (args.isEmpty) logger.info(message) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you split refactoring into another PR plz?
object Dependencies { | ||
val scala3 = "3.3.1" | ||
val scala213 = "2.13.12" | ||
val scala213 = "2.13.16" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be a separate PR
// Same as 0.13.x | ||
generateDispatchFromResource(style, "/httpclients_dispatch0130", config) | ||
case (VersionPattern(1, 0 | 1, _), style) => | ||
case (VersionPattern(1, 0 | 1 | 2, _), style) => |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we split these fixes to another PR and add a scripted test that's called only for JDK 11+?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure on the 2nd part of writing the scripted test case for JDK 11+ part. Can you guide me on how to achieve it?
closing this pull request. Will open new ones as per review comments. |
#603
Corrected Driver.scala version pattern match for dispatch-core 2.0.0 version.
Udpate Log4j to the latest 2.24.x and fixed Log.scala to support the updated log4j jars.
Update scala 2.13 version to the latest 2.13.16
Updated default version of Dispatch-core to 1.2.0 and updated the corresponding pattern to support the .y in Driver.scala