Feature/fix dispatch core 2 version #682
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… version are flagged in security scans. eed3si9n#673
…ing against this version. From the project the version of the dispatch-core can be configured using the configuration, compile / scalaxb / scalaxbDispatchVersion. Since the supporting templates are been added to the scalaxb, the dispatch-core 2.0.0 version should work fine. eed3si9n#673
Corrected Driver.scala version pattern match for dispatch-core 2.0.0 version. Udpate Log4j to the latest 2.24.x and fixed Log.scala to support the updated log4j jars. Update scala 2.13 version to the latest 2.13.16 Updated default version of Dispatch-core to 1.2.0 and updated the corresponding pattern to support the .y in Driver.scala
This reverts commit 9b10b6d.
Signed-off-by: Sumit <[email protected]>
eed3si9n
reviewed
Feb 12, 2025
| // Same as 0.13.x | ||
| generateDispatchFromResource(style, "/httpclients_dispatch0130", config) | ||
| case (VersionPattern(2, 0 | 2, _), style) => | ||
| case (VersionPattern(2, 0, _), style) => |
There was a problem hiding this comment.
Suggested change
| case (VersionPattern(2, 0, _), style) => | |
| case (VersionPattern(2, _, _), style) => |
I suggest wildcard match here so it matches all 2.x.
Signed-off-by: Sumit <[email protected]>
eed3si9n
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cleaning the pattern match for dispatch-core version and keeping it to the currently available 2.0.0 version.