Fixed observer race condition #206
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
superviewandisObservingScrollViewresulting in observed values getting emitted with no message handler. This ultimately results in a crash.Changes
superviewto remove the observer we can set theobserverourselves when it gets created. This eliminates the need to check if its of typeUIScrollViewand also eliminates the need forisObservingScrollViewsince we can use the class-levelobserverto check if one is set before removing it