Revert "Revert "feat(ci): write rntuples""#2654
Open
wdconinc wants to merge 3 commits into
Open
Conversation
This reverts commit aa6b3b5.
Added suppression for false positive in RNTuple reads.
Contributor
Contributor
There was a problem hiding this comment.
Pull request overview
Re-applies CI changes to write PODIO output as RNTuple and configure npsim to use RNTuple, after a previous revert. Adds suppressions for a known TSAN false positive and an LSAN entry related to RNTuple.
Changes:
- Enable
podio:output_backend=rntuplein JANA_OPTIONS and pass--outputConfig.useRNTuple trueto npsim invocations. - Add TSAN suppression for
ROOT::Internal::RCluster::Adopt(documented false positive). - Add LSAN suppression for
ROOT::new_ROOTcLcLRNTuple.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/linux-eic-shell.yml | Switches PODIO output and npsim output to RNTuple format. |
| .github/tsan.supp | Suppresses known false positive in RNTuple cluster adoption. |
| .github/lsan.supp | Suppresses leak attributed to ROOT RNTuple symbol. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #2653
As identified in root-project/root#22153 this is a false positive due to the compilation of only part of the stack with TSAN.