SVT random noise injection #2670
Open
ShujieL wants to merge 4 commits into
Open
Conversation
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce? Please link to any relevant presentations or discussions.
Inject random sensor noise to SVT (ECTRK, BVTX, BTRK). With provided number of noise hits per layer, the code uses a for loop to randomly select a sensitive module, then a position --> cell ID within that module to inject the noise hit. This mechanism works only if the layer has one uniform module shape and size.
Noise are created at RawHits level, then get combined with real hits before RecHits conversion.
To enable noise injection:
This PR based on the previous developments at #1988 and #2667. It has relevant changes cherry-picked for rebase, refactoring, and a few more updates to ensure the code serves the purpose.
What is the urgency of this PR?
What kind of change does this PR introduce?
Please check if any of the following apply
CODEX was used for refactoring and debugging.