fix(monero-sys): Correctly handle multiple transaction keys #629
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
…the transaction id for each tx key as well
…UnstoppableSwap/core into fix/monero-sys-multiple-tx-keys
This is annoying because it's increasing the diff size when I really just want to extract the changes into a patch.
…tput. Caviat: we currently skip all outputs that belong to the primary address. This means we won't have a tx key when sending to our own main address or for change outputs. Transactions which try anyway will fail in the rust verification step.
…our own main address
Author
|
bugbot run |
|
Skipping Bugbot: Bugbot is disabled for this repository |
|
bugbot run |
Author
|
|
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
…n fails (instead of ignoring it)
binarybaron
reviewed
Oct 24, 2025
|
whats blocking this from being merged? Maybe we can get a Monero developer to review our C++ patch? |
|
@SNeedlewoods Would you be interested in looking over our C++ patch here? |
jeffro256
reviewed
Oct 27, 2025
jeffro256
reviewed
Oct 27, 2025
jeffro256
reviewed
Oct 27, 2025
|
@jeffro256 thanks for the review! have you had a chance to look at the monero-sys/patches/eigenwallet_0003_pending_transaction_tx_keys.patch C++ patch? This is what we are most unsure about and where we are afraid to make mistakes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Add per-output Monero tx key extraction (incl. subaddresses), expose via FFI, update swap to use address-key map, and add new tests/CI entries.
eigenwallet_0003_pending_transaction_tx_keysto exposePendingTransaction::txKeys(...)returning(txid, address, key)tuples.TxKeystruct,pendingTransactionTxKeys(...)now returns rich keys; remove singlewalletGetTxKeypath.TxReceiptto holdtx_keys: HashMap<monero::Address, monero::PrivateKey>instead of singletx_key.PendingTransaction::validate_single_txid(...)maps output addresses to keys;publish_pending_transaction(...)acceptsoutput_addressesand returns mapped keys.WalletHandle::address(...), makecheck_tx_statuspublic; add helpers and minor logging/robustness tweaks.tests/transaction_keys.rs).receipt.tx_keysto select the key for the Monero lock address; build destinations with optional developer tip; adjust tests to pass tip as(ratio, use_subaddress).happy_path_alice_developer_tip_subaddress.Cli; add constructors with configurable background sync; exposecheck_tx_keyand address helpers.monero-testswith integration testtransfers.rs(tx proofs end-to-end); include in workspace.happy_path_alice_developer_tip_subaddressandmonero-tests/transactions.undo-monero-changeshelper.Written by Cursor Bugbot for commit 51b6acf. This will update automatically on new commits. Configure here.