feat: OrangeFren client #641
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
October 24, 2025 19:08
Signed-off-by: Maksim Kirillov <[email protected]>
binarybaron
reviewed
Nov 2, 2025
|
|
||
| let _ = client2.load_from_db(); | ||
|
|
||
| let mut updates = client2.watch_status(trade_id).await; |
There was a problem hiding this comment.
this doesn't really test if the database is used because watch_status(...) fetches the new status? we need a way to verify that there is state present (cached one) without fetching again
binarybaron
reviewed
Nov 2, 2025
orangefren-client/client/src/lib.rs
Outdated
| is_terminal: true, | ||
| description: e.to_string(), | ||
| valid_for: Duration::from_secs(30), | ||
| raw_json: "None".to_string(), |
There was a problem hiding this comment.
we never want to use stringy types, if this can be null, then use Option<_>
binarybaron
reviewed
Nov 2, 2025
orangefren-client/client/src/lib.rs
Outdated
|
|
||
| entry.1.push(status.clone()); | ||
|
|
||
| sqlx::query!( |
There was a problem hiding this comment.
This should be a wrapper function in database.rs. Try not to execute SQL statements outside of database.rs
binarybaron
reviewed
Nov 2, 2025
There was a problem hiding this comment.
good first draft! we also need a way to access more of the internal data (especially the deposit_address)
@Einliterflasche will give this another review too
general optimization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API for currnecy exchange service "orangefren"