forked from comit-network/xmr-btc-swap
-
Notifications
You must be signed in to change notification settings - Fork 28
feat: show list of subaddresses #685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rafael-xmr
wants to merge
1
commit into
eigenwallet:master
Choose a base branch
from
rafael-xmr:feat-subaddress-list
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
very cool! I'll review this ASAP |
|
Compilations fails with this error on my machine: |
|
bugbot run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Bugbot reviewed your changes and found no bugs!
binarybaron
reviewed
Nov 7, 2025
binarybaron
reviewed
Nov 7, 2025
binarybaron
reviewed
Nov 7, 2025
binarybaron
reviewed
Nov 7, 2025
binarybaron
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some more comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Add Monero subaddress listing (with received/tx counts), creation, and labeling, wired through FFI, Tauri commands/events, Redux, and a new UI modal/button.
monero-sys(numSubaddresses,getSubaddressLabel,addSubaddress,setSubaddressLabel).SubaddressSummaryand wallet methods to compute summaries per account (address, label, received, tx_count) and create/update subaddresses.get_monero_subaddresses,create_monero_subaddress,set_monero_subaddress_label(wired insrc-tauri/src/commands.rs).MoneroWalletUpdate::SubaddressesUpdatewith current summaries.SubaddressesModalto list subaddresses, copy addresses, show received/tx count, create new subaddress, and edit labels.WalletActionButtons.subaddressesto wallet state andsetSubaddressesaction; handleSubaddressesUpdateinbackground.ts.renderer/rpc.ts.Written by Cursor Bugbot for commit d893570. This will update automatically on new commits. Configure here.