Skip to content

Conversation

@naclonts
Copy link
Member

@naclonts naclonts commented Jan 5, 2026

Description

Update default cluster version to Kubernetes v1.34, which is the current EKS default in the DescribeClusterVersions API.

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

Copy link
Contributor

@torredil torredil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will also need to bump up cluster version here:

to fix unit test:

Summarizing 1 Failure:
  [FAIL] nodegroup filter ForEach [It] should iterate over unique nodegroups, apply defaults and validate

//TODO: Remove this and replace with output from DescribeClusterVersions endpoint
// DefaultVersion (default)
DefaultVersion = Version1_32
DefaultVersion = Version1_34
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool with doing this change

long term we should replace this with the api response, not sure how much effort that is

@naclonts
Copy link
Member Author

naclonts commented Jan 5, 2026

Will also need to bump up cluster version here:

Thanks for the tip - updated that test to use the api.DefaultVersion const as well.

@naclonts naclonts merged commit ace3ad1 into eksctl-io:main Jan 12, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants