Fix EFA interface count for instances where MaximumNetworkCards exceeds EFA limit#8692
Open
kprahulraj wants to merge 1 commit intoeksctl-io:mainfrom
Open
Fix EFA interface count for instances where MaximumNetworkCards exceeds EFA limit#8692kprahulraj wants to merge 1 commit intoeksctl-io:mainfrom
kprahulraj wants to merge 1 commit intoeksctl-io:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #8685
We tried to set EFA's by using MaximumNetworkCards. This worked for all previous EFA-capable instances in cases where
MaximumEfaInterfaces = MaximumNetworkCards, but starts to break in the latest instance types.To fix this using
NetworkInfo.EfaInfo.MaximumEfaInterfacesto determine the EFA interface count, with fallback toMaximumNetworkCardswhenEfaInfois not populated.Checklist
README.md, or theuserdocsdirectory)area/nodegroup) and kind (e.g.kind/improvement)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯